Repository navigation
chore: bump docker image versions - #1151
GemWalletBot wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the base image versions for Rust, Redis, Postgres, and Meilisearch in the Dockerfile and docker-compose.yml. The review feedback identifies that the versions specified for Rust (1.95.0), Redis (8.6-alpine), and Meilisearch (v1.44.0) are non-existent, which will cause build and deployment failures.
| @@ -1,5 +1,5 @@ | |||
| # syntax=docker/dockerfile:1 | |||
| FROM lukemathwalker/cargo-chef:latest-rust-1.94.1-bookworm AS chef | |||
| FROM lukemathwalker/cargo-chef:latest-rust-1.95.0-bookworm AS chef | |||
There was a problem hiding this comment.
The Rust version 1.95.0 specified in the image tag does not exist. As of early 2025, the latest stable version of Rust is 1.84.0. Using a non-existent version will cause the Docker build to fail because the image cannot be pulled from the registry.
FROM lukemathwalker/cargo-chef:latest-rust-1.84.0-bookworm AS chef
|
|
||
| redis: | ||
| image: redis:7.0-alpine | ||
| image: redis:8.6-alpine |
There was a problem hiding this comment.
Redis version 8.6-alpine is not a valid or released version. The current stable major version is 7 (with 7.4 being the latest stable release). While Redis 8.0 is in development, version 8.6 does not exist. This change will break the deployment as the image pull will fail.
image: redis:7.4-alpine|
|
||
| meilisearch: | ||
| image: getmeili/meilisearch:v1.21.0 | ||
| image: getmeili/meilisearch:v1.44.0 |
There was a problem hiding this comment.
Meilisearch version v1.44.0 does not exist. The current stable versioning is in the v1.12.x range. Please verify the intended version, as this will cause the container to fail to start due to a missing image.
image: getmeili/meilisearch:v1.12.1
Bumps stale/risky image pins:
redis:7.0-alpine→redis:8.6-alpine(7.0 is EOL)postgres:latest→postgres:17(pin to avoid surprise upgrades)getmeili/meilisearch:v1.21.0→getmeili/meilisearch:v1.44.0cargo-chef:latest-rust-1.94.1-bookworm→latest-rust-1.95.0-bookwormmeilisearchvolume before pulling the new image in prod in case the index format changed.