Stabilize inline visualization loading skeleton - #1555
Open
brsbl wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The compact inline-visualization loading state could be replaced by a full-height iframe, changing the timeline layout after navigation. Render a complete six-region skeleton immediately and reserve the preview height through the loading-to-iframe transition.
The skeleton uses shimmer-only paint animation, avoiding staged layout or entrance animation.
Changed files
plugins/inline-vis/app.tsx— fixed-height loading container and six-region skeleton.plugins/inline-vis/app.test.tsx— focused regression coverage for the skeleton structure, reserved height, and shimmer-only behavior.Validation
BB-Thread-ID: thr_g3y2kuichb