Fix timeline stabilization after turn completion - #1568
Open
ymichael wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
turn/completedarrives, preventing a stale active-turn projection from landing after the canonical completed projectionProblem
Long streaming responses can cross the timeline event budget while active, then change from a budget-cut in-turn projection to a canonical completed-turn projection. The normal streaming invalidation path deliberately avoids cancelling active reads and schedules a paced trailing refetch. At the terminal boundary, that allowed an older active response to briefly overwrite the completed shape before the trailing refetch corrected it. Animating the whole timeline height made the replacement look like the response was streaming in reverse.
This change keeps the non-cancelling behavior for ordinary stream events. Only the authoritative
turn/completedboundary cancels obsolete work and immediately requests the terminal shape.Testing
pnpm exec turbo run test --filter=@bb/app --force -- --run src/hooks/realtime-cache-effects.test.ts src/components/ui/height-transition.test.tsx— 46 tests passedpnpm exec turbo run typecheck --filter=@bb/app@bb/apptest suite — 340 files and 2,704 tests passed before the final rebase; the affected tests were rerun afterwardgit diff --check