Repository navigation
chore: read ASC key and issuer IDs from the environment in upload-testflight.sh - #840
Merged
Merged
Conversation
…tflight.sh The App Store Connect API Key ID and Issuer ID were hardcoded in the upload script. They now come from ASC_KEY_ID and ASC_ISSUER_ID, the names asc itself reads, and the script exits before any archive work when either is missing. The .p8 path stays derived from the Key ID. VERSIONING.md and the testflight-build skill list the required exports. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 19 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
scripts/upload-testflight.shno longer hardcodes the App Store Connect API Key ID and Issuer ID. It reads them from the environment:ASC_KEY_IDASC_ISSUER_IDThese are the names
ascitself reads (checked against asc 4.2.0), so the same exports also serve as its fallback credentials.Why
Account identifiers belong in the operator's environment, not in a tracked script.
How
require_envguard runs right aftercdto the repo root, before reading any plist, resolving packages or archiving. A missing or empty variable exits 1 with the variable's name, where to find it, and a placeholder export..p8path stays derived from the Key ID:~/.asc/keys/AuthKey_<ASC_KEY_ID>.p8.docs/VERSIONING.md(upload runbook) and.claude/skills/testflight-build/SKILL.md(step 2) list the exports, placeholders only.Setting the variables
App Store Connect > Users and Access > Integrations > App Store Connect API (Team Keys):
Put them in
~/.zshrc(or equivalent) before the next upload, or the script stops at the guard.Validation
bash -n,sh -n,shellcheck: clean.ASC_ISSUER_IDunset, and withASC_KEY_IDempty: each exits 1 at the guard, naming the right variable. No archive, export or upload ran, and the tree stayed clean.git grep: the previous literal values no longer appear in the tree. They remain in git history.🤖 Generated with Claude Code