Repository navigation
docs: clarify Premium recurring top-up setup - #714
Merged
Merged
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
anhtho-lago
marked this pull request as ready for review
October 17, 2026 05:41
sarkissianraffi
approved these changes
Oct 17, 2026
sarkissianraffi
left a comment
Contributor
There was a problem hiding this comment.
No blockers.
What held up (checked against lago-api main, not the PR text)
- Premium gate:
Wallets::RecurringTransactionRules::CreateService#callreturns early unlessLicense.premium?, andWallets::UpdateServiceguardsrecurring_transaction_rulesthe same way. The new note is accurate. - Credit availability:
Invoices::PrepaidCreditJobgrants credits only when the payment status issucceeded(and not paid by credit note). "Available only after payment succeeds" matches. - The Stripe guide path
guide/payments/stripe-integration.mdxexists on this branch, so the link resolves. - The only
2022date in the file is gone. The threshold tab label fix (intervaltothreshold) is correct against the surrounding steps.
Non-blocking
- The note says the purchase invoice is marked
succeeded. The API field ispayment_status. Considerpayment_statusset tosucceededso integrators can map it to the field. - The threshold example still shows
invoice_requires_successful_payment: truenext to the new note. Consider one sentence on how that flag interacts with credit availability, since it is the setting that decides whether the invoice finalizes before payment. - The PR says no end-to-end Premium plus Stripe test was run. I did not run one either. Mint validate was not re-run by me; I only checked the content claims.
Merge order: no overlap found with the other open PR touching the wallet guides. Safe to merge on its own.
Generated by Claude Code
sarkissianraffi
approved these changes
Oct 17, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The recurring top-up guide currently omits the Premium requirement and uses an expired 2022 wallet date in both API examples. A buyer following those examples could misread what is included or create a wallet that has already expired.
Description
Validation
pnpm exec mint validatepassed locally.git diff --checkpassed.validateandMintlify Deploymentchecks passed.2022-07-07date.This corrects one guide; it does not claim an end-to-end Premium Cloud and Stripe test. The guide should still be tested with a Premium Cloud organization and Stripe test connection before using it as a verified buyer benchmark.