Skip to content

docs: clarify Premium recurring top-up setup - #714

Merged
sarkissianraffi merged 1 commit into
mainfrom
codex/recurring-topup-guide
Oct 17, 2026
Merged

sarkissianraffi merged 1 commit into
mainfrom
codex/recurring-topup-guide

Conversation

@anhtho-lago

@anhtho-lago anhtho-lago commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Context

The recurring top-up guide currently omits the Premium requirement and uses an expired 2022 wallet date in both API examples. A buyer following those examples could misread what is included or create a wallet that has already expired.

Description

  • Mark recurring rules as a Lago Premium capability, matching the current API license guard.
  • Link the existing Stripe setup guide for automatic paid collection and state that purchased credits become usable after payment succeeds.
  • Remove the expired optional wallet dates from both examples and correct the threshold tab's label.

Validation

  • pnpm exec mint validate passed locally.
  • git diff --check passed.
  • GitHub validate and Mintlify Deployment checks passed.
  • The hosted HTML preview and Markdown fallback both returned HTTP 200 and contain the corrected wording. The fallback has no expired 2022-07-07 date.

This corrects one guide; it does not claim an end-to-end Premium Cloud and Stripe test. The guide should still be tested with a Premium Cloud organization and Stripe test connection before using it as a verified buyer benchmark.

@mintlify

mintlify Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
lago-docs 🟢 Ready View Preview Oct 17, 2026, 5:41 AM

💡 Tip: Enable Automations to automatically generate PRs for you.

@sarkissianraffi sarkissianraffi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blockers.

What held up (checked against lago-api main, not the PR text)

  • Premium gate: Wallets::RecurringTransactionRules::CreateService#call returns early unless License.premium?, and Wallets::UpdateService guards recurring_transaction_rules the same way. The new note is accurate.
  • Credit availability: Invoices::PrepaidCreditJob grants credits only when the payment status is succeeded (and not paid by credit note). "Available only after payment succeeds" matches.
  • The Stripe guide path guide/payments/stripe-integration.mdx exists on this branch, so the link resolves.
  • The only 2022 date in the file is gone. The threshold tab label fix (interval to threshold) is correct against the surrounding steps.

Non-blocking

  • The note says the purchase invoice is marked succeeded. The API field is payment_status. Consider payment_status set to succeeded so integrators can map it to the field.
  • The threshold example still shows invoice_requires_successful_payment: true next to the new note. Consider one sentence on how that flag interacts with credit availability, since it is the setting that decides whether the invoice finalizes before payment.
  • The PR says no end-to-end Premium plus Stripe test was run. I did not run one either. Mint validate was not re-run by me; I only checked the content claims.

Merge order: no overlap found with the other open PR touching the wallet guides. Safe to merge on its own.


Generated by Claude Code

@sarkissianraffi
sarkissianraffi merged commit e52a7a4 into main Oct 17, 2026
2 checks passed
@sarkissianraffi
sarkissianraffi deleted the codex/recurring-topup-guide branch October 17, 2026 06:05

This branch was successfully deployed

1 active deployment
staging — beb5493b Deployed Oct 17, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants