Repository navigation
build: Drop removed extras from make install - #592
Merged
Merged
Conversation
The avro, json and msgpack extras were removed from setup.py when the codecs were dropped in #219, but `make install` and `make docs` still request them, so every install prints three "does not provide the extra" warnings. Install the package without extras; nothing else changes.
untitaker
approved these changes
Oct 29, 2026
mwarkentin
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
avro,jsonandmsgpackextras were removed fromsetup.pywhen the codecs were dropped in #219, butmake installandmake docsstill request them, so every install prints three "does not provide the extra" warnings. This installs the package without extras in both targets; nothing else changes.Verified in a fresh Python 3.13 venv:
make installon main prints the three warnings, and on this branch installs cleanly with no warnings.