ref(logs): Intercept Native SDK logs by lucas-zimerman · Pull Request #1249 · getsentry/sentry-capacitor

lucas-zimerman · 2026-05-18T22:31:59Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Based on getsentry/sentry-react-native#5622
This PR redirects native Sentry logs to be visible along with the JavaScript logs

💡 Motivation and Context

Allow users to see all SDK logs on a unified way.

💚 How did you test it?

Android logs

iOS

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

Close #1093

…gs to JS Migrated from sentry-react-native#5622. Adds an `onNativeLog` option that lets users surface native SDK logs (e.g. HTTP 413 transport errors) in the browser console when `debug: true` is set. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…fyListeners Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-authored-by: Claude <noreply@anthropic.com>

…/sentry-capacitor into lz/intercept-js-errors

…o resolve Swift concurrency warning Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

antonis · 2026-05-19T07:33:36Z

q: Is the move of Package.resolved moved to root intentional?

not really, let me rollback

antonis

Other than the package move LGTM

SDK libraries should not commit Package.resolved — SPM ignores it from dependencies and only the consuming app's lock file is used. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

lucas-zimerman · 2026-05-22T20:03:56Z

@@ -1,23 +0,0 @@
-{


Tooling opted to not have this file

cursor · 2026-05-22T20:10:19Z

+    androidLogger.log(level, message, args);
+
+    String formattedMessage =
+        (args == null || args.length == 0) ? message : String.format(message, args);


Unprotected String.format can throw uncaught exception

Medium Severity

The String.format(message, args) calls in the log methods are not wrapped in try-catch. The underlying AndroidLogger.log() internally catches IllegalFormatException from malformed format strings (this was a known crash, sentry-java#1985), but the subsequent String.format call in CapSentryLogger lacks this same protection. If format specifiers in message don't match args, an IllegalFormatException will propagate uncaught into the SDK internals.

Additional Locations (1)

android/src/main/java/io/sentry/capacitor/CapSentryLogger.java#L50-L52

^{Reviewed by Cursor Bugbot for commit 19cae50. Configure here.}

antonis

LGTM 🎸

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

There are 3 total unresolved issues (including 1 from previous review).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit d8d9fc9. Configure here.}

cursor · 2026-06-02T22:19:05Z

+export function setupNativeLogListener(callback: (log: NativeLogEntry) => void): void {
+  if (_removeListener) {
+    return;
+  }


Re-init leaves log listener active

Medium Severity

Calling Sentry.init again without close() can leave native log forwarding enabled when debug is later false, and a second init with debug: true will not replace onNativeLog because setupNativeLogListener exits when a listener already exists and sdkInit only registers a listener when debug is true, never tearing it down on init.

Additional Locations (2)

src/client.ts#L54-L58

ios/Sources/SentryCapacitorPlugin/SentryCapacitorPlugin.swift#L87-L90

^{Reviewed by Cursor Bugbot for commit d8d9fc9. Configure here.}

cursor · 2026-06-02T22:19:05Z

+      data.put("level", level.name().toLowerCase());
+      data.put("component", "Sentry");
+      data.put("message", message);
+      currentEmitter.emit(data);


Android forwards logs without debug

Medium Severity

On Android, every native Sentry log is emitted over the Capacitor bridge via notifyListeners whenever the plugin loads, even when debug is false and JavaScript never registers SentryNativeLog, unlike iOS where forwarding is configured only when native debug is enabled.

Additional Locations (1)

android/src/main/java/io/sentry/capacitor/SentryCapacitor.java#L55-L58

^{Reviewed by Cursor Bugbot for commit d8d9fc9. Configure here.}

lucas-zimerman and others added 6 commits May 16, 2026 02:29

fix(NativeLogListener): remove unnecessary type assertion on addListener

daa6dff

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix(android): remove jetbrains annotations from CapSentryLogger

7e72b97

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix(android): use emitter interface to avoid protected access on noti…

ffa7a37

…fyListeners Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

plugin order

53a676f

validated changes on ios

75f7180

lucas-zimerman changed the title ~~Lz/intercept js errors~~ ref(logs): Intercept Native errors May 18, 2026

lucas-zimerman and others added 2 commits May 19, 2026 00:20

added tests

9efaf0b

Co-authored-by: Claude <noreply@anthropic.com>

Merge branch 'lz/intercept-js-errors' of https://github.com/getsentry…

23a1725

…/sentry-capacitor into lz/intercept-js-errors

lucas-zimerman added the ready-to-merge label May 18, 2026

Merge branch 'main' into lz/intercept-js-errors

4a12586

lucas-zimerman changed the title ~~ref(logs): Intercept Native errors~~ ref(logs): Intercept Native SDK logs May 18, 2026

lucas-zimerman and others added 4 commits May 19, 2026 00:31

changelog

ef826eb

merge main

713f6d4

Merge branch 'lz/intercept-js-errors' of https://github.com/getsentry…

1562275

…/sentry-capacitor into lz/intercept-js-errors

fix(ios): mark NativeLogsForwarder as final and @unchecked Sendable t…

99baf27

…o resolve Swift concurrency warning Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

lucas-zimerman marked this pull request as ready for review May 18, 2026 23:56

lucas-zimerman requested a review from antonis May 18, 2026 23:56

cursor Bot reviewed May 18, 2026

View reviewed changes

Comment thread src/client.ts

antonis reviewed May 19, 2026

View reviewed changes

This comment was marked as spam.

Sign in to view

lucas-zimerman and others added 2 commits May 22, 2026 20:58

chore: remove Package.resolved and add to .gitignore

cb40606

SDK libraries should not commit Package.resolved — SPM ignores it from dependencies and only the consuming app's lock file is used. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

chore: anchor Package.resolved gitignore rule to repo root

19cae50

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

lucas-zimerman commented May 22, 2026

View reviewed changes

lucas-zimerman requested a review from antonis May 22, 2026 20:04

cursor Bot reviewed May 22, 2026

View reviewed changes

antonis approved these changes May 26, 2026

View reviewed changes

Merge branch 'main' into lz/intercept-js-errors

d8d9fc9

cursor Bot reviewed Jun 2, 2026

View reviewed changes

lucas-zimerman merged commit fbef6fb into main Jun 2, 2026
22 checks passed

lucas-zimerman deleted the lz/intercept-js-errors branch June 2, 2026 22:25

sentry-release-bot Bot mentioned this pull request Jun 10, 2026

publish: getsentry/sentry-capacitor@4.1.0 getsentry/publish#8514

Closed

3 tasks

Navigation Menu

Repository navigation

ref(logs): Intercept Native SDK logs - #1249

ref(logs): Intercept Native SDK logs#1249
lucas-zimerman merged 16 commits into
mainfrom
lz/intercept-js-errors

lucas-zimerman commented May 18, 2026 •

edited

Loading

Uh oh!

Uh oh!

antonis May 19, 2026

Uh oh!

lucas-zimerman May 22, 2026

Uh oh!

antonis left a comment

Uh oh!

This comment was marked as spam.

Uh oh!

lucas-zimerman May 22, 2026

Uh oh!

cursor Bot May 22, 2026

Uh oh!

antonis left a comment

Uh oh!

cursor Bot left a comment

Uh oh!

cursor Bot Jun 2, 2026

Uh oh!

cursor Bot Jun 2, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

lucas-zimerman commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

Uh oh!

antonis May 19, 2026

Choose a reason for hiding this comment

Uh oh!

lucas-zimerman May 22, 2026

Choose a reason for hiding this comment

Uh oh!

antonis left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

lucas-zimerman May 22, 2026

Choose a reason for hiding this comment

Uh oh!

cursor Bot May 22, 2026

Choose a reason for hiding this comment

Unprotected String.format can throw uncaught exception

Uh oh!

antonis left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot Jun 2, 2026

Choose a reason for hiding this comment

Re-init leaves log listener active

Uh oh!

cursor Bot Jun 2, 2026

Choose a reason for hiding this comment

Android forwards logs without debug

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lucas-zimerman commented May 18, 2026 •

edited

Loading

Unprotected `String.format` can throw uncaught exception