Skip to content

ref(transport): introduce transport boundary - #1446

Open
giortzisg wants to merge 1 commit into
fix/http-transport-deliveryfrom
ref/transport-envelope-contract
Open

giortzisg wants to merge 1 commit into
fix/http-transport-deliveryfrom
ref/transport-envelope-contract

Conversation

@giortzisg

@giortzisg giortzisg commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Description

Establish a common envelope-based contract for transports and loss accounting. This removes IsRateLimited from the public transport API and encapsulates it's functionality inside the transport.

#skip-changelog

Issues

Changelog Entry Instructions

To add a custom changelog entry, uncomment the section above. Supports:

  • Single entry: just write text
  • Multiple entries: use bullet points
  • Nested bullets: indent 4+ spaces

For more details: custom changelog entries

Reminders

Stack created with GitHub Stacks CLI • Give Feedback 💬

@giortzisg
giortzisg added this pull request to stack #1448 October 5, 2026 14:29

@szokeasaurusrex szokeasaurusrex left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable

@giortzisg
giortzisg force-pushed the ref/transport-envelope-contract branch from 867fc4b to bfa64eb Compare October 8, 2026 12:42
@giortzisg
giortzisg force-pushed the ref/transport-envelope-contract branch 2 times, most recently from b4e6f56 to 8a48aa0 Compare October 9, 2026 08:36
@giortzisg
giortzisg force-pushed the ref/transport-envelope-contract branch from 8a48aa0 to 748fa42 Compare October 12, 2026 12:57
@giortzisg
giortzisg removed this pull request from stack #1448 October 12, 2026 13:04
@giortzisg
giortzisg added this pull request to stack #1452 October 12, 2026 13:04
@giortzisg
giortzisg removed this pull request from stack #1452 October 12, 2026 14:07
@giortzisg
giortzisg added this pull request to stack #1455 October 12, 2026 14:08
@giortzisg
giortzisg removed this pull request from stack #1455 October 12, 2026 14:09
@giortzisg
giortzisg added this pull request to stack #1456 October 12, 2026 14:11
@giortzisg
giortzisg force-pushed the ref/transport-envelope-contract branch from 748fa42 to 838f0f3 Compare October 12, 2026 15:46
@giortzisg
giortzisg force-pushed the ref/transport-envelope-contract branch from 838f0f3 to 35fb505 Compare October 12, 2026 15:57
@giortzisg
giortzisg force-pushed the ref/transport-envelope-contract branch from 35fb505 to e6bce41 Compare October 13, 2026 10:18

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e6bce41. Configure here.

Comment thread transport_legacy.go
reason = report.ReasonQueueOverflow
}
a.recorder.RecordForEnvelope(reason, envelope)
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queue overflow outcomes not recorded

Medium Severity

AsyncTransport.SendEnvelope no longer records a full queue, and internalAsyncTransportAdapter only does so when recorder is set. The telemetry processor installs that adapter without a recorder, so SendEvent drops on ErrTransportQueueFull (and other send errors) never reach client reports.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit e6bce41. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e6bce41. Configure here.

Comment thread transport_legacy.go
This folds the ratelimited and capacity functionalities under transport
so that users should only use SendEnvelope as public API
@giortzisg
giortzisg force-pushed the ref/transport-envelope-contract branch from e6bce41 to 706a711 Compare October 13, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants