Skip to content

ref(openai-agents): Drop support for stream_gen_ai_spans - #7362

Open
alexander-alderman-webb wants to merge 1 commit into
major/3.0from
webb/openai-agents/remove-stream-gen-ai-spans
Open

ref(openai-agents): Drop support for stream_gen_ai_spans#7362
alexander-alderman-webb wants to merge 1 commit into
major/3.0from
webb/openai-agents/remove-stream-gen-ai-spans

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Description

Set stream_gen_ai_spans=False to maintain assertions for the static trace lifecycle.
Transaction support will be removed as a follow up.

Issues

Reminders

@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review September 3, 2026 11:23
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner September 3, 2026 11:23

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit fba0f5e. Configure here.

Comment thread sentry_sdk/integrations/openai_agents/spans/invoke_agent.py
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

115121 passed | ❌ 1 failed | ⏭️ 5526 skipped | Total: 120648 | Pass Rate: 95.42% | Execution Time: 379m 45s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -17047
Passed Tests 📉 -15464
Failed Tests 📈 +1
Skipped Tests 📉 -1584

➕ New Tests (1)

View new tests
  • test_user_ip_address_on_all_spans[data_collection_wins_over_send_default_pii_false]
    • File: tests.integrations.sanic.test_sanic
    • Status: ❌ Failing

❌ Failed Tests

test_user_ip_address_on_all_spans[data_collection_wins_over_send_default_pii_false]

File: tests.integrations.sanic.test_sanic
Suite: py3.11-sanic-v23.12.2
Error: OSError: [Errno 98] error while attempting to bind on address ('127.0.0.1', 42335): address already in use

Stack Trace
tests/integrations/sanic/test_sanic.py:589: in test_user_ip_address_on_all_spans
    with c as client:
../../_temp/uv-python-dir/cpython-3.11.16-linux-x86_64-gnu/lib/python3.11/contextlib.py:137: in __enter__
    return next(self.gen)
           ^^^^^^^^^^^^^^
tests/integrations/sanic/test_sanic.py:96: in reusable_client
    client.__enter__()
.tox/py3.11-sanic-v23.12.2/lib/python3.11/site-packages/sanic_testing/reusable.py:65: in __enter__
    self.run()
.tox/py3.11-sanic-v23.12.2/lib/python3.11/site-packages/sanic_testing/reusable.py:77: in run
    self._server = self._run(self._server_co)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^
.tox/py3.11-sanic-v23.12.2/lib/python3.11/site-packages/sanic_testing/reusable.py:198: in _run
    return self._loop.run_until_complete(coro)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../../_temp/uv-python-dir/cpython-3.11.16-linux-x86_64-gnu/lib/python3.11/asyncio/base_events.py:654: in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
.tox/py3.11-sanic-v23.12.2/lib/python3.11/site-packages/sanic/mixins/startup.py:612: in create_server
    return await serve(
.tox/py3.11-sanic-v23.12.2/lib/python3.11/site-packages/sanic/server/async_server.py:113: in __await__
    self.server = task.result()
                  ^^^^^^^^^^^^^
../../_temp/uv-python-dir/cpython-3.11.16-linux-x86_64-gnu/lib/python3.11/asyncio/base_events.py:1536: in create_server
    raise OSError(err.errno, msg) from None
E   OSError: [Errno 98] error while attempting to bind on address ('127.0.0.1', 42335): address already in use

✅ Patch coverage is 100.00%. Project has 2262 uncovered lines.
✅ Project coverage is 90.44%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    90.24%    90.44%     +0.2%
==========================================
  Files          193       185        -8
  Lines        25715     23671     -2044
  Branches      9502      8704      -798
==========================================
+ Hits         23206     21409     -1797
- Misses        2509      2262      -247
- Partials      1435      1363       -72

Generated by Codecov Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants