Skip to content

test(profiler): Wait for automatic shutdown - #7364

Merged
sl0thentr0py merged 2 commits into
masterfrom
fix/continuous-profiler-test-race
Sep 3, 2026
Merged

test(profiler): Wait for automatic shutdown#7364
sl0thentr0py merged 2 commits into
masterfrom
fix/continuous-profiler-test-race

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

The automatic profiler lifecycle shuts down asynchronously after inactive profiles are observed by the sampler. Replace the fixed 200 ms sleeps with a bounded wait for both shutdown and the resulting profile chunk, so loaded CI workers cannot race the assertion.

Requested by neel.

--

View Junior Session [Sentry]

Co-Authored-By: Neel Shah <6536764+sl0thentr0py@users.noreply.github.com>
@sl0thentr0py
sl0thentr0py marked this pull request as ready for review September 3, 2026 11:37
@sl0thentr0py
sl0thentr0py requested a review from a team as a code owner September 3, 2026 11:37
@sl0thentr0py
sl0thentr0py enabled auto-merge (squash) September 3, 2026 11:40
Comment thread tests/profiler/test_continuous_profiler.py Outdated
@sl0thentr0py
sl0thentr0py merged commit 8e54169 into master Sep 3, 2026
164 checks passed
@sl0thentr0py
sl0thentr0py deleted the fix/continuous-profiler-test-race branch September 3, 2026 11:56
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

130585 passed | ⏭️ 7110 skipped | Total: 137695 | Pass Rate: 94.84% | Execution Time: 465m 50s

📊 Comparison with Base Branch

Metric Change
Total Tests
Passed Tests
Failed Tests
Skipped Tests

✨ No test changes detected

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2509 uncovered lines.
✅ Project coverage is 90.24%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    90.24%    90.24%        —%
==========================================
  Files          193       193         —
  Lines        25715     25715         —
  Branches      9502      9502         —
==========================================
+ Hits         23206     23206         —
- Misses        2509      2509         —
- Partials      1435      1433        -2

Generated by Codecov Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant