chore(openai): Remove transaction-based tracing - #7366
Open
alexander-alderman-webb wants to merge 4 commits into
Open
chore(openai): Remove transaction-based tracing#7366alexander-alderman-webb wants to merge 4 commits into
alexander-alderman-webb wants to merge 4 commits into
Conversation
alexander-alderman-webb
changed the title
alexander-alderman-webb
marked this pull request as ready for review
September 3, 2026 12:01
Contributor
Codecov Results 📊✅ 94208 passed | ❌ 22 failed | ⏭️ 3927 skipped | Total: 98157 | Pass Rate: 95.98% | Execution Time: 332m 3s 📊 Comparison with Base Branch
➕ New Tests (22)View new tests
❌ Failed Tests
|
| File | Patch % | Lines |
|---|---|---|
| sentry_sdk/integrations/openai.py | 98.25% |
Coverage diff
@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 90.24% 90.36% +0.12%
==========================================
Files 193 185 -8
Lines 25715 23471 -2244
Branches 9502 8618 -884
==========================================
+ Hits 23206 21209 -1997
- Misses 2509 2262 -247
- Partials 1433 1358 -75Generated by Codecov Action
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 236cb6f. Configure here.
| model="gpt-4o", | ||
| instructions="You are a coding assistant that talks like a pirate.", | ||
| input="How do I check if a Python object is an instance of a class?", | ||
| ) |
There was a problem hiding this comment.
Missing pytest.raises lets exception crash error-handling tests
High Severity
The pytest.raises(OpenAIError) context manager was removed along with the start_span wrapper, but it was the only thing catching the expected OpenAIError. The mock is configured with side_effect=OpenAIError(...), and the implementation calls reraise after capturing the exception. Without pytest.raises, the OpenAIError propagates uncaught, crashing both test_error_in_responses_api and test_error_in_responses_async_api before any assertions are reached.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 236cb6f. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issues
Closes #7102
Reminders
uv run ruff.feat:,fix:,ref:,meta:)