Skip to content

test(e2e): Evaluate replay assertion on Android #6684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antonis wants to merge 1 commit into
base: test/restore-replay-e2e-assertion
Choose a base branch
from
+10 −11
Open

test(e2e): Evaluate replay assertion on Android #6684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions dev-packages/e2e-tests/maestro/captureReplay.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,11 @@ jsEngine: graaljs
env:
replaysOnErrorSampleRate: 1.0
# Prime the native replay buffer before capturing the exception so a replay_id
# is attached to the event (iOS only; Android does not reliably capture replays
# in CI — see https://github.com/getsentry/sentry-react-native/pull/4277).
- runFlow:
file: utils/primeReplayBuffer.yml
when:
platform: iOS
# is attached to the event. Runs on both platforms: Android historically did not
# reliably capture replays in CI (see
# https://github.com/getsentry/sentry-react-native/pull/4277); this re-evaluates
# that with deterministic buffer priming.
- runFlow: utils/primeReplayBuffer.yml
- tapOn: "Capture Exception"
- runFlow: utils/assertEventIdVisible.yml
- runFlow:
file: utils/assertReplay.yml
when:
platform: iOS
- runFlow: utils/assertReplay.yml
5 changes: 4 additions & 1 deletion dev-packages/e2e-tests/maestro/utils/assertReplay.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,7 @@ jsEngine: graaljs
- assertTrue: ${output.replayId}
- assertTrue: ${output.replayDuration}
- assertTrue: ${output.replaySegments}
- assertTrue: ${output.replayCodec == "ftypmp42"}
# Assert a valid MP4 container was produced (the "ftyp" box at byte offset 4)
# rather than a platform-specific major brand: iOS (AVAssetWriter) emits "mp42"
# while Android (MediaMuxer) may emit a different brand such as "isom".
- assertTrue: ${output.replayCodec.startsWith("ftyp")}
Loading