Repository navigation
ref(rollout): Switch gocd tracking logic to rollout in all regions - #8608
Merged
Merged
Conversation
snuba-api is an Argo Rollout (workloadRef) in every region. Deploy api with k8s-deploy --type=rollout everywhere so GoCD waits for the Rollout to become Healthy, and raise the deploy-primary timeout to fit canary steps and analyses.
ElioDiNino
approved these changes
Oct 26, 2026
MeredithAnya
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8606, which switched s4s2 only.
Turn on tracking rollout resource for all regions.
Verified gocd logic here https://deploy.getsentry.net/go/tab/build/detail/deploy-snuba-s4s2/98/deploy-primary/1/deploy-primary