Skip to content

feat(eap): start MODE_LOW_PRIORITY queries at TIER_8 - #8611

Merged
pbhandari merged 4 commits into
masterfrom
prajjwalbhandari/eap-865-add-the-ability-to-query-low-fidelity-data
Oct 27, 2026
Merged

pbhandari merged 4 commits into
masterfrom
prajjwalbhandari/eap-865-add-the-ability-to-query-low-fidelity-data

Conversation

@pbhandari

Copy link
Copy Markdown
Contributor

Fixes EAP-865

MODE_LOW_PRIORITY uses the same OutcomesBased path as MODE_NORMAL, but starts at TIER_8 instead of TIER_1. Further downsample to TIER_64 / TIER_512 still happens when ingest is too large.

https://linear.app/getsentry/issue/EAP-865/add-the-ability-to-query-low-fidelity-data

@linear-code

linear-code Bot commented Oct 27, 2026

Copy link
Copy Markdown

EAP-865

@pbhandari
pbhandari marked this pull request as ready for review October 27, 2026 19:35
@pbhandari
pbhandari requested review from a team as code owners October 27, 2026 19:35

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 406c7ef. Configure here.

== DownsampledStorageConfig.MODE_LOW_PRIORITY
):
tier = max(tier, Tier.TIER_8)
return tier

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low priority flagged as routing mistake

Low Severity

MODE_LOW_PRIORITY now starts at TIER_8 by design, but _emit_routing_mistake still treats any non-TIER_1 query that finishes under the sampled-too-low threshold as a routing_mistake. Fast low-priority queries will emit false sampled_too_low metrics.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 406c7ef. Configure here.

@onewland onewland left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you still want to have some floor for small customers before we shift off TIER_1. Product relies on us to know total ingest volume; we can't rely on them only sending LOW_PRIORITY for big customers.

@pbhandari
pbhandari merged commit a5de68a into master Oct 27, 2026
69 checks passed
@pbhandari
pbhandari deleted the prajjwalbhandari/eap-865-add-the-ability-to-query-low-fidelity-data branch October 27, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants