Repository navigation
Test the runner images in a dedicated runner-images PR check - #4313
Draft
henrymercer wants to merge 6 commits into
Draft
henrymercer wants to merge 6 commits into
henrymercer wants to merge 6 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…nked` Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the expanded runner-image coverage and simplified CodeQL workflow.
No open issues 🎉
What changed in this PR
This PR moves runner-image coverage into a dedicated integration check and simplifies the repository’s own CodeQL analysis workflow, following the runner cleanup in #4309.
Changes:
- Replaces
linux-arm64with a 12-imagerunner-imagescheck using the linked CodeQL bundle, including Swift analysis on macOS. - Consolidates repository analysis into an Actions/JavaScript language matrix using the default bundle and
build-mode: none. - Enables automatic retries for failed runner-image checks through Deflake.
| File | Description |
|---|---|
pr-checks/checks/runner-images.yml |
Adds cross-platform integration coverage. |
pr-checks/checks/linux-arm64.yml |
Removes the superseded Arm64-only check. |
.github/workflows/deflake.yml |
Adds the runner-images workflow to automatic retries. |
.github/workflows/codeql.yml |
Consolidates analysis jobs and removes bundle-version comparison. |
.github/workflows/__runner-images.yml |
Generates the expanded runner-image workflow. |
.github/codeql/codeql-config-actions.yml |
Extracts the existing Actions analysis configuration. |
Review effort: Balanced (auto)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on from #4309, this PR ensures that the PR checks cover the images listed in the runner images README.
linux-arm64check is renamed torunner-images, and now runs on each image listed in the README, apart from the exceptions below. On macOS, it also analyzes Swift. It tests the linked CodeQL version, since other checks cover the supported versions. The Linux Arm64 job previously usednightly-latestbecause releases before CodeQL 2.27.0 had no Linux Arm64 bundle. The macOS jobs use larger runners to keep them off the critical path.codeqlworkflow now has a single matrixedanalyzejob, replacinganalyze-javascriptandanalyze-other. It runs onubuntu-26.04with the default CodeQL bundle, since other checks cover the runner images and CodeQL versions, so thecheck-codeql-versionsjob is no longer needed. Both languages now usebuild-mode: none, and the Actions configuration has moved to.github/codeql/codeql-config-actions.yml.runner-imagesjobs, as it does for thecodeqlworkflow.This leaves
ubuntu-slimandwindows-11-armuntested, sinceubuntu-slimis intended for lightweight jobs and CodeQL doesn't support Windows on Arm64. Thexcode-27preview image is only covered by theunsupported-macoscheck.The Ubuntu 22.04 images have brownouts from 23 March 2027 (actions/runner-images#14254), so we'll need to remove them before then.
I'm investigating some automation to maintain the set of tested runner images as a potential followup PR.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Environments:
How did/will you validate this change?
pr-checks).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
pr-checks/sync-checks.tsbefore it can merge. The release branches will pick up the workflow change in the next release, as they did for Removemacos-13fromcodeqlworkflow #3274. After merging, the previousanalyze-javascriptandanalyze-otherconfigurations will probably need deleting from the code scanning tool status page, since those jobs have been replaced.Merge / deployment checklist