-
Notifications
You must be signed in to change notification settings - Fork 2k
Enhance Vue Router useRoute query support and documentation #22209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adrienpessu
wants to merge
12
commits into
github:main
Choose a base branch
from
adrienpessu:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7ef911e
Model Vue Router useRoute sources
Copilot 7449658
Test Vue useRoute query source
Copilot 9aaa149
Add change note for Vue Router useRoute query support
Copilot 03d2ad5
Add YYYY-MM-DD format change note for Vue Router useRoute query
Copilot 7e08178
Add Vue summary models for ref, shallowRef, toRef, reactive, and comp…
Copilot dfb0487
Merge pull request #1 from adrienpessu/copilot/add-codeql-model-for-u…
adrienpessu dc15554
Move Vue flow models into QL
Copilot d99bb54
Fix and verify Vue flow summaries
Copilot c5b3ca0
Merge Vue change notes
Copilot f329988
Merge pull request #2 from adrienpessu/copilot/modify-vue-qll-for-mai…
adrienpessu 0f8f884
Add Vue toRef value-flow and computed object-overload tests
adrienpessu ceed0c3
Merge pull request #3 from adrienpessu/adrienpessu-vue-toref-computed…
adrienpessu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
javascript/ql/lib/change-notes/2026-07-16-vue-router-useRoute-query.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| category: minorAnalysis | ||
| --- | ||
| * The query parameter of Vue Router's `useRoute()` Composition API is now recognized as a client-side remote flow source. | ||
| * Added flow models for Vue's `ref`, `shallowRef`, `toRef`, `reactive`, and `computed` Composition API helpers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| extensions: | ||
| - addsTo: | ||
| pack: codeql/javascript-all | ||
| extensible: summaryModel | ||
| data: | ||
| # `computed(() => ...)` — function overload: the getter's return value flows to `.value`. | ||
| - ["vue", "Member[computed]", "Argument[0].ReturnValue", "ReturnValue.Member[value]", "value"] | ||
| # `computed({ get() { ... } })` — object overload: the `get` getter's return value flows to `.value`. | ||
| - ["vue", "Member[computed]", "Argument[0].Member[get].ReturnValue", "ReturnValue.Member[value]", "value"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -115,3 +115,10 @@ let subclass2 = base.extend({ | |
| fromSubclass2: 100 | ||
| } | ||
| }); | ||
|
|
||
| sink(Vue.ref(source("ref")).value); | ||
| sink(Vue.shallowRef(source("shallowRef")).value); | ||
| sink(Vue.toRef(source("toRef")).value); | ||
|
|
||
| sink(Vue.reactive(source("reactive"))); | ||
| sink(Vue.computed(() => source("computed")).value); | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @copilot implement this fix |
||
| sink(Vue.computed({ get() { return source("computedObject"); }, set(v) {} }).value); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot implement this fix