Repository navigation
refactor: unify Cookie API to return string and map[string]string - #24
Merged
Merged
Conversation
- Change Cookie() return type from *fasthttp.Cookie to string - Change Cookies() return type from []*fasthttp.Cookie to map[string]string - Fix dangling pointer bug in cookie() method - Update all tests and examples to use new API - Align with framework style (Query, Param, Header methods)
- Change Cookie() return type from *fasthttp.Cookie to string - Change Cookies() return type from []*fasthttp.Cookie to map[string]string - Fix dangling pointer bug in cookie() method - Update all tests and examples to use new API - Align with framework style (Query, Param, Header methods)
…to refactor/cookie-api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR unifies the Cookie API to align with the framework's design style.
Breaking Changes
Cookie()return type changed from*fasthttp.CookietostringCookies()return type changed from[]*fasthttp.Cookietomap[string]stringBug Fixes
cookie()methodAPI Changes
Before
After
Benefits
fasthttptypes