Accept hyphen grouping in credit_card validation - #1626
Open
official-burak wants to merge 1 commit into
Open
official-burak wants to merge 1 commit into
official-burak wants to merge 1 commit into
Conversation
Spaces were already stripped before the Luhn check, so a number like 4624 7482 3324 9780 passed, but the same digits with hyphens did not. Hyphens are now treated as the same grouping separator. Double hyphens still fail, matching the existing double-space rule. Fixes go-playground#1624
nodivbyzero
reviewed
Sep 10, 2026
| val := fl.Field().String() | ||
| // Hyphens are a common grouping separator (Visa 4-4-4-4, Amex 4-6-5). | ||
| // Treat them like spaces so the existing segment rules still apply. | ||
| val := strings.ReplaceAll(fl.Field().String(), "-", " ") |
Contributor
There was a problem hiding this comment.
Using strings.ReplaceAll, strings.Split, bytes.Buffer, and strings.Split(..., "") creates multiple unnecessary string and slice allocations.
It would be nice to see a version which processes the string in a single pass, allocates memory only once, validates that only digits/spaces/hyphens are present and then uses Luhn checker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
credit_card already splits on spaces before the Luhn check, so 4624 7482 3324 9780 is valid, but the same digits with hyphens are not. Hyphens are now treated as the same grouping separator, so Visa 4-4-4-4 and Amex 4-6-5 work. Double hyphens still fail, matching the existing double-space rule.
Fixes #1624
Make sure that you've checked the boxes below before you submit PR:
@go-playground/validator-maintainers