Skip to content

Make metadata use EditorPropertyVariant in the inspector - #123534

Open
YeldhamDev wants to merge 1 commit into
godotengine:masterfrom
YeldhamDev:metadata_epvar
Open

YeldhamDev wants to merge 1 commit into
godotengine:masterfrom
YeldhamDev:metadata_epvar

Conversation

@YeldhamDev

Copy link
Copy Markdown
Member

What problem(s) does this PR solve?

This PR makes so that metadata properties use EditorPropertyVariant. This allows to change their type without the need to delete and recreate them.

@KoBeWi

KoBeWi commented Sep 16, 2026

Copy link
Copy Markdown
Member

#113678

@YeldhamDev

Copy link
Copy Markdown
Member Author

Crap, didn't notice your PR, sorry.

The way you handled the PropertyInfo is way better than my hack, but I'm not so sure about the way the variant list was handled. Even if a little more convoluted, I think it's more future-proof to add a way to set the exceptions and renames.

@KoBeWi

KoBeWi commented Sep 17, 2026

Copy link
Copy Markdown
Member

Even if a little more convoluted, I think it's more future-proof to add a way to set the exceptions and renames.

Yeah, but my workaround is very minimal, so it's easy to replace if needed. And we won't need to change it probably until major Variant changes, which are still rather far away.

@YeldhamDev

Copy link
Copy Markdown
Member Author

Ehh, very well. That PR needs to be rebased, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants