Conversation
kitbdev
force-pushed
the
focus-scripteditor-on-tab-click
branch
from
September 22, 2026 19:41
cdde67e to
b4308be
Compare
Contributor
Author
Now uses |
Member
Isn't |
Contributor
Author
It's not enough, especially for shader editor which needs to be able to open without taking any focus when clicking on nodes. |
kitbdev
force-pushed
the
focus-scripteditor-on-tab-click
branch
from
September 26, 2026 17:43
b4308be to
21432f8
Compare
kitbdev
force-pushed
the
focus-scripteditor-on-tab-click
branch
from
September 26, 2026 17:56
21432f8 to
901e28c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem(s) does this PR solve?
This makes many actions focus on the Script Editor/Shader Editor text. Including clicking on the Script / Shader Editor tab, using the shortcut (including when its already open), using the Editor Dock menu option, restoring after floating, and using
EditorInterface.set_main_screen_editor("Script").Also applies when they are floating.
These either match 4.7.2 behavior or shouldn't cause any issues.
Additional information
Adds a callback when a dock is focused (unexposed). The Script Editor uses this to move the focus to its CodeEdit. Also applies to Shader Editor.
When a tab is clicked it now calls
focus_dock. I don't think this has an effect in most cases since the tab would already be focused.Also moved
ScriptEditor::update_layoutsince it was near the unrelatedScriptEditorQuickOpenmethods.