Add native touch support to PopupMenu - #123576
Merged
Repiteo merged 1 commit intoSep 22, 2026
Merged
Conversation
m4gr3d
reviewed
Sep 17, 2026
m4gr3d
reviewed
Sep 17, 2026
m4gr3d
reviewed
Sep 17, 2026
m4gr3d
left a comment
m4gr3d
left a comment
Contributor
There was a problem hiding this comment.
Can you add a recording to showcase the new touch functionality.
syntaxerror247
force-pushed
the
popup-menu-touch-support
branch
from
September 17, 2026 19:04
02e1ca4 to
662cd38
Compare
syntaxerror247
changed the title
PopupMenu
m4gr3d
approved these changes
Sep 17, 2026
m4gr3d
left a comment
m4gr3d
left a comment
Contributor
There was a problem hiding this comment.
The code looks good, and I tested the feature and it works as expected!
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds native touch support to PopupMenu.
As shown in this video, this change enables drag scrolling.
Note: The large scrollbar shown in the video is specific to the editor. Since such large scrollbars will no longer be necessary, its size will be reduced in a follow-up PR.
Screen_recording_20260918_003249.mp4