GDScript replace SuiteNode::Local::UNDEFINED with nullptr - #123582
Open
HolonProduction wants to merge 1 commit into
Open
HolonProduction wants to merge 1 commit into
HolonProduction wants to merge 1 commit into
Conversation
HolonProduction
force-pushed
the
what-do-you-mean-undefined
branch
from
September 22, 2026 09:09
dce3276 to
fbe5b86
Compare
HolonProduction
marked this pull request as ready for review
September 22, 2026 10:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem(s) does this PR solve?
Requires Fix
LocalVector<T>::clearwhenThas no default constructor #123581Get's rid of the
UNDEFINEDlocal type in the GDScript AST which we have been using as invalid default value. In general I want to adopt an "You have something valid or nothing" approach were possible. We currently have "You have something that might be invalid", which is bloating our switch statements with cases that should never happen in practice.