Skip to content

tutorial: omit hostname from router.Run in web-service-gin - #1774

Closed
tyrellcurry wants to merge 1 commit into
golang:masterfrom
tyrellcurry:tc-web-service-gin-readme
Closed

tyrellcurry wants to merge 1 commit into
golang:masterfrom
tyrellcurry:tc-web-service-gin-readme

Conversation

@tyrellcurry

Copy link
Copy Markdown

Update the web-service-gin tutorial to call router.Run(":8080") instead of router.Run("localhost:8080"). Binding to localhost prevents the tutorial from working in environments where the client and server are not on the same loopback interface, such as Google Cloud Shell, where following the tutorial verbatim produces:

  $ curl http://localhost:8080/albums
  curl: (7) Failed to connect to localhost port 8080 after
  0 ms: Couldn't connect to server

Omitting the hostname binds to all available interfaces and matches the convention used in Gin's own documentation, letting the curl command in the tutorial succeed in these environments.

@google-cla

google-cla Bot commented Jun 13, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@tyrellcurry

Copy link
Copy Markdown
Author

/please-cla-recheck

@tyrellcurry

Copy link
Copy Markdown
Author

Closing in favor of a fresh PR with a properly formatted body (no markdown, hard-wrapped at 72 chars). Reopening shortly from the same branch.

@gopherbot

Copy link
Copy Markdown

This PR (HEAD: ec42809) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tour/+/790460.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants