Repository navigation
tutorial: omit hostname from router.Run in web-service-gin - #1774
Closed
tyrellcurry wants to merge 1 commit into
Closed
tyrellcurry wants to merge 1 commit into
tyrellcurry wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
/please-cla-recheck |
Author
|
Closing in favor of a fresh PR with a properly formatted body (no markdown, hard-wrapped at 72 chars). Reopening shortly from the same branch. |
|
This PR (HEAD: ec42809) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tour/+/790460. Important tips:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the web-service-gin tutorial to call router.Run(":8080") instead of router.Run("localhost:8080"). Binding to localhost prevents the tutorial from working in environments where the client and server are not on the same loopback interface, such as Google Cloud Shell, where following the tutorial verbatim produces:
$ curl http://localhost:8080/albums curl: (7) Failed to connect to localhost port 8080 after 0 ms: Couldn't connect to serverOmitting the hostname binds to all available interfaces and matches the convention used in Gin's own documentation, letting the curl command in the tutorial succeed in these environments.