Skip to content

Keep weighted_distribution_ in sync with records_ when pruning all-zero weights. #2275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Keep weighted_distribution_ in sync with records_ when pruning all-zero weights. #2275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions centipede/corpus.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,8 @@ size_t Corpus::Prune(const FeatureSet &fs,
subset_to_remove.erase(
subset_to_remove.begin() +
absl::Uniform<size_t>(rng, 0, subset_to_remove.size()));
// Restore one weight since RemoveRandomWeightedSubset removed all of them.
weighted_distribution_.AddWeight(0);
}
RemoveSubset(subset_to_remove, records_);

Expand Down
17 changes: 17 additions & 0 deletions centipede/corpus_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,23 @@ TEST(Corpus, PruneCorpusWithAllEmptyFeatureInputs) {
corpus.Prune(fs, coverage_frontier, max_corpus_size, rng);
}

TEST(Corpus, PruneCorpusWithAllZeroWeights) {
Corpus corpus;
Rng rng(0);

// Newly added inputs have weight 0 before UpdateWeights is called.
corpus.Add({1}, {}, {}, {}, FeatureSet(1, {}),
CoverageFrontier(BinaryInfo{}));
corpus.Add({2}, {}, {}, {}, FeatureSet(1, {}),
CoverageFrontier(BinaryInfo{}));

EXPECT_EQ(corpus.Prune(FeatureSet(1, {}), CoverageFrontier(BinaryInfo{}),
/*max_corpus_size=*/1000, rng),
1);
EXPECT_EQ(corpus.NumActive(), 1);
EXPECT_EQ(corpus.WeightedRandom(rng), 0);
}

// Regression test for a crash in Corpus::Prune().
TEST(Corpus, PruneRegressionTest1) {
PCTable pc_table(100);
Expand Down
Loading