Conversation
Member
|
Thanks, I agree mmap and Windows will not fail with an unaligned length. |
Author
|
Thanks @jan-wassenberg! Updated the PR to require |
jan-wassenberg
approved these changes
Sep 15, 2026
jan-wassenberg
left a comment
Member
There was a problem hiding this comment.
Nice, thanks for making the change!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1031.
Checkpoints padded to 256-byte blob boundaries currently fall back to reading when their sizes are not multiples of the system page size. Relax the loader guard to
kBlobAlignso these checkpoints can use mmap while retaining the alignment requirement for kernels that read ahead.kBlobAlignbetween the blob store and weight loader, and correct the comment about page-aligned file lengths.Validation
weights_test: 6 tests passed.blob_store_test: 2 tests passed.git diff --checkand formatting checks passed.