Skip to content

protos: Add GPU domain IDs to GPU tracks and counters - #8763

Merged
dreveman merged 1 commit into
mainfrom
dev/dreveman/gpu-counter-descriptor
Nov 21, 2026
Merged

dreveman merged 1 commit into
mainfrom
dev/dreveman/gpu-counter-descriptor

Conversation

@dreveman

@dreveman dreveman commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Let GPU TrackDescriptors and GPU counter descriptors identify the domain of the GPU they belong to with a gpu_domain_id scoped to the GPU. A domain can be a hardware block, such as an SM or a PE, or a producer-defined logical grouping. Like gpu_id, this identifies the same domain in both data sources without either referencing the other, so that GPU counters can be associated with the detailed track events of the domain they measure and its hardware queues, the way processes and threads are.

Producers use one counter descriptor per domain, so a sample takes one GpuCounterEvent per domain, each still encoding any subset of that domain's counters.

Test plan:
tools/gen_merged_protos, contrib/rust-sdk/tools/gen_rust_protos, building trace_processor_shell and perfetto, and tools/run_presubmit.

@dreveman
dreveman requested a review from a team as a code owner November 20, 2026 02:25
@dreveman

Copy link
Copy Markdown
Collaborator Author

@LalitMaganti this is the last of the proto changes needed to provide full integration of GPU events with the track event machinery. Some TP/UI changes will follow to support this but it provides a huge amount of flexibility when it comes to adding custom GPU events and annotating existing events using sibling tracks and different track merging behaviors.

@dreveman
dreveman force-pushed the dev/dreveman/gpu-counter-descriptor branch from 917e754 to ea1ed5d Compare November 20, 2026 03:48
@dreveman
dreveman force-pushed the dev/dreveman/gpu-counter-descriptor branch from ea1ed5d to f95d4d3 Compare November 20, 2026 14:23
Comment thread protos/perfetto/trace/gpu/BUILD.gn Resolved
@dreveman
dreveman force-pushed the dev/dreveman/gpu-counter-descriptor branch from f95d4d3 to 2b96cd4 Compare November 21, 2026 01:57
Let GPU TrackDescriptors and GPU counter descriptors identify the domain
of the GPU they belong to with a `gpu_domain_id` scoped to the GPU. A
domain can be a hardware block, such as an SM or a PE, or a
producer-defined logical grouping. Like `gpu_id`, this identifies the
same domain in both data sources without either referencing the other,
so that GPU counters can be associated with the detailed track events of
the domain they measure and its hardware queues, the way processes and
threads are.

Producers use one counter descriptor per domain, so a sample takes one
`GpuCounterEvent` per domain, each still encoding any subset of that
domain's counters.

Test plan:
`tools/gen_merged_protos`, `contrib/rust-sdk/tools/gen_rust_protos`,
building `trace_processor_shell` and `perfetto`, and
`tools/run_presubmit`.
@dreveman
dreveman force-pushed the dev/dreveman/gpu-counter-descriptor branch from 2b96cd4 to 6b67af0 Compare November 21, 2026 02:10
@dreveman dreveman changed the title protos: Bind GPU counters to GPU TrackDescriptors protos: Add GPU domain IDs to GPU tracks and counters Nov 21, 2026
@dreveman
dreveman merged commit aeb4477 into main Nov 21, 2026
33 checks passed
@dreveman
dreveman deleted the dev/dreveman/gpu-counter-descriptor branch November 21, 2026 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants