Repository navigation
protos: Add GPU domain IDs to GPU tracks and counters - #8763
Merged
Merged
Conversation
Collaborator
Author
|
@LalitMaganti this is the last of the proto changes needed to provide full integration of GPU events with the track event machinery. Some TP/UI changes will follow to support this but it provides a huge amount of flexibility when it comes to adding custom GPU events and annotating existing events using sibling tracks and different track merging behaviors. |
🎨 Perfetto UI Builds & Tests
|
dreveman
force-pushed
the
dev/dreveman/gpu-counter-descriptor
branch
from
November 20, 2026 03:48
917e754 to
ea1ed5d
Compare
dreveman
force-pushed
the
dev/dreveman/gpu-counter-descriptor
branch
from
November 20, 2026 14:23
ea1ed5d to
f95d4d3
Compare
dreveman
force-pushed
the
dev/dreveman/gpu-counter-descriptor
branch
from
November 21, 2026 01:57
f95d4d3 to
2b96cd4
Compare
Let GPU TrackDescriptors and GPU counter descriptors identify the domain of the GPU they belong to with a `gpu_domain_id` scoped to the GPU. A domain can be a hardware block, such as an SM or a PE, or a producer-defined logical grouping. Like `gpu_id`, this identifies the same domain in both data sources without either referencing the other, so that GPU counters can be associated with the detailed track events of the domain they measure and its hardware queues, the way processes and threads are. Producers use one counter descriptor per domain, so a sample takes one `GpuCounterEvent` per domain, each still encoding any subset of that domain's counters. Test plan: `tools/gen_merged_protos`, `contrib/rust-sdk/tools/gen_rust_protos`, building `trace_processor_shell` and `perfetto`, and `tools/run_presubmit`.
dreveman
force-pushed
the
dev/dreveman/gpu-counter-descriptor
branch
from
November 21, 2026 02:10
2b96cd4 to
6b67af0
Compare
LalitMaganti
approved these changes
Nov 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let GPU TrackDescriptors and GPU counter descriptors identify the domain of the GPU they belong to with a
gpu_domain_idscoped to the GPU. A domain can be a hardware block, such as an SM or a PE, or a producer-defined logical grouping. Likegpu_id, this identifies the same domain in both data sources without either referencing the other, so that GPU counters can be associated with the detailed track events of the domain they measure and its hardware queues, the way processes and threads are.Producers use one counter descriptor per domain, so a sample takes one
GpuCounterEventper domain, each still encoding any subset of that domain's counters.Test plan:
tools/gen_merged_protos,contrib/rust-sdk/tools/gen_rust_protos, buildingtrace_processor_shellandperfetto, andtools/run_presubmit.