[ir] Add explicit active_outputs_ready signal to controlled stages - #4796
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_966078764
branch
2 times, most recently
from
August 20, 2026 16:48
ddc3138 to
0109f6b
Compare
By managing this separately, we can clean up our code. We were previously overloading this signal onto `outputs_valid`, causing significant confusion & complicating some upcoming improvements. This of course required updating our flow-control logic in Codegen 1.5, as well as our ScheduledBlock IR parsing logic. PiperOrigin-RevId: 967904645
copybara-service
Bot
force-pushed
the
test_966078764
branch
from
August 20, 2026 17:28
0109f6b to
2b40de6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ir] Add explicit
active_outputs_readysignal to controlled stagesBy managing this separately, we can clean up our code. We were previously overloading this signal onto
outputs_valid, causing significant confusion & complicating some upcoming improvements.This of course required updating our flow-control logic in Codegen 1.5, as well as our ScheduledBlock IR parsing logic.