Added assert_ne builtin to DSLX - #4798
Open
achowd32 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt to (partially) address #4227. This PR is fairly straightforward, it just adds an
assert_nebuiltin. I mostly mimicked the structure of the existingassert_eqand changed whatever was necessary. This is my first contribution to the actual interpreter and IR side of the project, so please let me know if I made any mistakes - I would be happy to learn and fix them.If everything is deemed okay, I am also happy to add more assert builtins (e.g.
assert_gt, assert_le) in a future PR, if so desired.