Skip to content

fix: enable .sync shortcut for $ presets - #1423

Merged
antongolub merged 5 commits into
google:mainfrom
antongolub:fix-sync-presets
Feb 25, 2026
Merged

antongolub merged 5 commits into
google:mainfrom
antongolub:fix-sync-presets

Conversation

@antongolub

@antongolub antongolub commented Feb 25, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes #1376

import {$} from 'zx'

assert.equal($({ nothrow: true }).sync`exit 1`.exitCode, 1)
assert.equal($.sync({ nothrow: true })`exit 2`.exitCode, 2)
  • Setup Set the latest Node.js LTS version.
  • Build: I’ve run npm build before committing and verified the bundle updates correctly.
  • Tests: I’ve run test and confirmed all tests succeed. Added tests to cover my changes if needed.
  • Docs: I’ve added or updated relevant documentation as needed.
  • Sign Commits have verified signatures and follow conventinal commits spec
  • CoC: My changes follow the project’s coding guidelines and Code of Conduct.
  • Review: This PR represents original work and is not solely generated by AI tools.

@antongolub antongolub self-assigned this Feb 25, 2026
@antongolub
antongolub requested a review from antonmedv February 25, 2026 10:54
@antongolub antongolub added the bug label Feb 25, 2026
@antongolub
antongolub merged commit 7a0f133 into google:main Feb 25, 2026
30 checks passed
@antongolub
antongolub deleted the fix-sync-presets branch February 25, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: sync field is undefined for custom preset create by $({})

1 participant