Repository navigation
Conversation
Clarify how cd() inside within() modifies process.cwd() globally while within() restores only the zx $ context, and provide code examples showing both the default behavior and restored behavior when syncProcessCwd() is enabled. Fixes google#876. Signed-off-by: Aryan Sachin <aryansachinixd@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issue #876 notes that \cd()\ modifies \process.cwd()\ globally across the entire process, while \within()\ restores only zx's internal $\ working directory context. Users relying on Node fs operations or relative paths inside separate callbacks can encounter unexpected directory state without realizing the difference.
Solution
Document the async context interaction between \within(), \cd(), and \syncProcessCwd(). Provide concrete code examples showing the default behavior vs the restored behavior with \syncProcessCwd()\ enabled, and guidance on using $.cwd\ for scoped zx directory changes.
Fixes #876.