Repository navigation
#1388 fix: align indented code block threshold with CommonMark - #1537
Closed
Anjaliavv51 wants to merge 2 commits into
Closed
Anjaliavv51 wants to merge 2 commits into
Anjaliavv51 wants to merge 2 commits into
Conversation
#1388 fix: align indented code block threshold with CommonMark
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1388
Problem
Running
zx README.mdfails withSyntaxError: Unexpected identifier 'assumes'when a Markdown file contains 2-space indented prose inside a list item.While PR #1419 addressed indented code fences, the Markdown processor's
tabRe = /^( +|\t)/matches 2 or more spaces after a blank line. Consequently, continuing prose indented under a list item with 2 spaces is classified as raw code instead of Markdown prose (which should be commented out with//).Solution
Per CommonMark specifications (Section 4.4), indented code blocks require 4 spaces or a tab. Update
tabRefrom/^( +|\t)/to/^( {4,}|\t)/so that 2-space indented list prose is preserved as comments and only true indented code blocks (4+ spaces or tabs) are emitted as raw code.