Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces comprehensive system tests for the resumable upload feature in the GAPIC generator. It adds conditional imports and setup for ResumableUploadServiceClient and its REST interceptor in conftest.py, along with helper functions to initiate and resume uploads. It also adds four new test files covering progress tracking, resumption scenarios, error recovery paths, and stall/deadline controls. There are no review comments, so I have no feedback to provide.
f0defed to
bae5b33
Compare
39c26aa to
f8fa453
Compare
bae5b33 to
ed209a5
Compare
| if not HAS_RESUMABLE_UPLOAD_CLIENT or not HAS_RESUMABLE_UPLOAD_INTERCEPTOR: | ||
| pytest.skip("ResumableUploadServiceClient not available.") | ||
|
|
||
| transport_name = "rest" |
There was a problem hiding this comment.
We need tests starting from clients created with grpc transports too, because those are the ones I'm more concerned about
I worry some of these fixtures are obscuring important details here Do we have any tests that go from creating a client to reading the result, exactly we expect end-users would?
78beac8 to
be137fe
Compare
be137fe to
54952a9
Compare
d6b2985 to
7f0f479
Compare
This branch has not been deployed
2 participants
No description provided.