docs: add v1.17.4 and v1.18.1 upgrade notes - #200
Open
goravel-coder wants to merge 3 commits into
Open
Conversation
hwbrzzl
reviewed
Sep 3, 2026
|
|
||
| ## v1.17.4 | ||
|
|
||
| - [Fix Orm.Connection() cached path poisoning dbConfig](#fix-orm-connection-cached-path-poisoning-dbconfig) |
Contributor
There was a problem hiding this comment.
You described this issue based on the actual code, but I want you to describe this based on the real user issue.
| ## v1.18.1 | ||
|
|
||
| - [Fix Orm.Connection() cached path poisoning dbConfig](#fix-orm-connection-cached-path-poisoning-dbconfig) | ||
| - [Fix package views registered in Boot() not rendering](#fix-package-views-registered-in-boot-not-rendering) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Connection()write the second ledger row to the wrong database goravel#987 fix from the real user issue instead of internal code mechanics: two or more migrations in the same batch that return the same non-default connection fromConnection()used to record the second migration's ledger row on that connection and fail with atable doesn't existerror — the note now explains that each migration still runs on its declared connection while its ledger row is recorded on the default connection, matching Laravel's behavior.View.LoadViewsFrom()in a provider'sBoot()are picked up and render correctly (View.LoadViewsFrom()has no effect — gin driver compiles templates before the provider Boot phase goravel#989).Why
These upgrade notes record two patch releases, v1.17.4 and v1.18.1, that ship two user-facing bug fixes. The note for goravel/goravel#987 (goravel/framework#1544 and goravel/framework#1545) was originally written from the perspective of the internal code change and has been rewritten to describe the real user issue. When two or more migrations in the same batch declare the same non-default connection, the second migration's ledger row was recorded on that connection instead of the default one, so the migration failed with a
table doesn't existerror because nomigrationstable existed on the non-default connection:After the fix each migration still runs on its declared connection, while its ledger row is recorded on the default connection — matching Laravel's behavior — so the migration batch completes without the
table doesn't existfailure.The same releases also fix goravel/goravel#989 in the Gin and Fiber drivers (goravel/gin#243 and goravel/fiber#297): the default template set used to be compiled when the route engine was built — before service providers boot — so views registered through
LoadViewsFrom()in a provider'sBoot()were missing from the compiled set:Rendering those package views at request time previously failed. The drivers now compile the default template set lazily on the first serve call (
Run/Listen/ServeHTTP), after all providers have booted, soLoadViewsFrom()-registered views are rendered correctly.