Skip to content

fix: panic when write on closed channel - #1035

Open
jmattheis wants to merge 1 commit into
masterfrom
panic
Open

fix: panic when write on closed channel#1035
jmattheis wants to merge 1 commit into
masterfrom
panic

Conversation

@jmattheis

Copy link
Copy Markdown
Member

This fixes panic: send on closed channel which can be triggered by "POSTing /message" and then closing the websocket connection client side.

Reported privately by @skeletonsec.

@jmattheis
jmattheis requested a review from a team as a code owner August 21, 2026 12:02
@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 75.47%. Comparing base (6933034) to head (eec23c7).

Files with missing lines Patch % Lines
api/stream/stream.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1035      +/-   ##
==========================================
- Coverage   75.47%   75.47%   -0.01%     
==========================================
  Files          66       66              
  Lines        3556     3559       +3     
==========================================
+ Hits         2684     2686       +2     
- Misses        662      663       +1     
  Partials      210      210              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant