perf: avoid quadratic accumulator rebuilds in item params - #314
Merged
daniil-filippov-dev merged 1 commit intoAug 12, 2026
Merged
Conversation
getMapItemsIgnores, getItemsParams and getItemsStateAndParams rebuilt their
accumulator on every item ({...acc, [id]: value}), making them O(n^2) in the
number of items.
On a dashboard with 19k items getMapItemsIgnores alone took ~72s; after the
change ~8ms. Behaviour is unchanged - the accumulator was a local object in
every case.
chrstnv
requested review from
Marginy605,
daniil-filippov-dev,
mournfulCoroner and
roberthovsepyan
as code owners
August 11, 2026 17:40
Contributor
|
Preview is ready. |
daniil-filippov-dev
approved these changes
Aug 12, 2026
mournfulCoroner
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getMapItemsIgnores,getItemsParamsandgetItemsStateAndParamsrebuilt their accumulator on every item ({...acc, [id]: value}), which is O(n²) in the number of itemsgetMapItemsIgnoresalone took ~72s, after the change ~8ms