feat: warn about unsupported dots in spec property keys - #393
Merged
Conversation
i-doshechnikow
requested review from
NasgulNexus and
bocembocem
as code owners
August 12, 2026 14:48
Contributor
|
Preview is ready. |
Contributor
|
Playwright Test Component is ready. |
bocembocem
reviewed
Aug 21, 2026
| ); | ||
| } | ||
| } | ||
| }, [spec]); |
Collaborator
There was a problem hiding this comment.
This rule applies to both modes, so this log also needs to be added for DynamicField
bocembocem
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Spec property keys containing dots (
a.b) are not supported: the library follows the final-form field name convention, where a dot is a path separator. Such specs are currently accepted silently and their values are lost during rendering (titles render, data does not) — hard to diagnose when the keys come from an external data source (e.g. Helm values).Change
DynamicViewemits a dev-onlyconsole.warnlisting the offending property keys, collected recursively (nested objects and array items included).Tests
Note: the branch history contains an earlier rendering fix and its revert — the approach was changed after discussion with maintainers in favor of an explicit warning; commits squash on merge.
🇷🇺 Описание на русском
Что и зачем
Ключи
spec.propertiesс точками (a.b) не поддерживаются: библиотека следует конвенции именования полей final-form, где точка — разделитель пути. Сейчас такие спеки принимаются молча, а значения теряются при рендере (заголовки рисуются, данные — нет) — это трудно диагностировать, когда ключи приходят из внешнего источника (например, Helm values).Изменение
DynamicViewвыводит dev-onlyconsole.warnсо списком проблемных ключей, собранных рекурсивно (включая вложенные объекты и элементы массивов).Тесты
Примечание: в истории ветки есть более ранний фикс рендера и его revert — после обсуждения с мейнтейнерами подход заменён на явный ворнинг; при мерже коммиты схлопнутся squash'ем.
🤖 Generated with Claude Code