ci: add a minimal v1 to v2 transition setup - #335
Open
draedful wants to merge 14 commits into
Open
Conversation
Contributor
|
Preview is ready. |
draedful
marked this pull request as ready for review
August 21, 2026 13:06
Reviewer's GuideSets up a minimal, temporary infrastructure to develop and validate a v2 line alongside the existing v1 on main by extending CI/E2E coverage to the v2 branch, adding an isolated v2 Storybook preview and manual prerelease workflow, and documenting branch, release, and cutover rules for the v1→v2 transition. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new sentence added to CONTRIBUTING.md (
For branch and release guidance during the v2 work, see the) is incomplete—link it explicitly to the new v1-v2 transition document or finish the sentence so readers can find the guidance. - In the new workflows,
v2-preview.ymlstill usesactions/checkout@v3andactions/setup-node@v3while other workflows use@v4; consider standardizing on the same major versions for consistency and easier maintenance. - The v2 prerelease workflow runs Node 24 while other workflows use Node 20; if there is no strong reason for this difference, consider aligning the Node version or adding a brief comment explaining why the release job requires a newer runtime.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new sentence added to CONTRIBUTING.md (`For branch and release guidance during the v2 work, see the`) is incomplete—link it explicitly to the new v1-v2 transition document or finish the sentence so readers can find the guidance.
- In the new workflows, `v2-preview.yml` still uses `actions/checkout@v3` and `actions/setup-node@v3` while other workflows use `@v4`; consider standardizing on the same major versions for consistency and easier maintenance.
- The v2 prerelease workflow runs Node 24 while other workflows use Node 20; if there is no strong reason for this difference, consider aligning the Node version or adding a brief comment explaining why the release job requires a newer runtime.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Collaborator
Author
|
@sourcery-ai review |
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The workflows currently mix Node 20 (CI/e2e/preview) and Node 24 (v2 prerelease); consider standardizing on a single Node version or explicitly documenting the intentional difference to avoid subtle environment drift between build, test, and release paths.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The workflows currently mix Node 20 (CI/e2e/preview) and Node 24 (v2 prerelease); consider standardizing on a single Node version or explicitly documenting the intentional difference to avoid subtle environment drift between build, test, and release paths.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a deliberately small temporary setup for developing v2 while
maincontinues to ship v1.mainandv2;/graph/v2/preview;next;The previous ruleset framework, routing validator, templates, API snapshot, consumer matrix, role system, and SHA ledger have intentionally been removed. Two maintainers will handle the occasional v1-to-v2 synchronization through normal PR review during the expected 1–2 month transition.
The TypeScript declaration packaging issue discovered during this work is intentionally deferred. It should be addressed separately on the v1 maintenance branch or through a more complete types design.
Safety
v2orrelease/v1.v2ref.next, neverlatest.mainrelease and preview behavior is preserved.Validation
npm run typechecknpm run build:publishnpm run test: 31 suites, 339 tests passedgit diff --checkRelated: #310, #312, #313, #314, #315, #316, #317.
Summary by Sourcery
Establish a temporary parallel v1/v2 development and release setup while keeping
mainstable and preparing v2 for the eventual cutover.New Features:
/graph/v2/.nextnpm dist-tag.Enhancements:
mainandv2branches.CI:
v2while preserving existingmainbehavior.Deployment:
v2branch.Documentation:
Chores: