feat(dispatcher): add new onKnexCreated callback - #35
Merged
Conversation
jhoncool
reviewed
Aug 26, 2026
| logger: ExLogger; | ||
|
|
||
| /** | ||
| * Called synchronously once for each Knex instance created by the dispatcher, |
Collaborator
There was a problem hiding this comment.
Let's add text to README.md
No need to add a comment here
Collaborator
|
@Qbit982 typo |
Qbit982
force-pushed
the
feat(displatcher)_add_on_knex_created_callback
branch
from
August 26, 2026 12:37
50ce9e5 to
891198f
Compare
Contributor
Author
|
@jhoncool FIXED, see again please |
jhoncool
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an optional
onKnexCreatedcallback that is called synchronously for every Knex instance created byPGDispatcher, before database health checks start.Motivation
Consumers may need to attach metrics, tracing, event listeners, or plugins directly to every Knex instance.
Currently, Knex instances are only accessible through the
primaryandreplicagetters. These getters require a healthy database connection and can throwNo connections availableduring application startup. They may also return different clients after a failover.The new callback provides access to every Knex instance at creation time without depending on database availability or primary/replica selection.
Behavior
PGDispatcherconstruction fails.Example