Repository navigation
fix: bound stream trimming and recover persistence workers - #33
Open
stanley2058 wants to merge 1 commit into
Open
stanley2058 wants to merge 1 commit into
stanley2058 wants to merge 1 commit into
Conversation
stanley2058
added this pull request to stack #34
October 5, 2026 07:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
🤖 GPT-6-Astra responding on behalf of Stanley
Builds on #32.
This PR fixes stream trimming and persistence worker recovery:
Server-side persistence flow:
flowchart TD A[Acquire persistence lease] --> B{Lease acquired?} B -->|No| C[Leave updates for the current owner] B -->|Yes| D[Load snapshot and stream position] D --> E{Worker ready?} E -->|No| F[Save snapshot directly] E -->|Yes| G[Send snapshot with requestId] G --> H[Wait for a matching worker reply] H -.->|Ignore stale or mismatched replies| H F -->|Success| I[Trim only saved entries older than the retention cutoff] H -->|Success| I F -->|Failure| J[Keep stream entries and schedule retry] H -->|Failure, exit, or replacement| J J --> AAdds 11 regression tests covering delayed saves, updates in the same millisecond, retention, reclaimed tasks, out-of-order updates, failed saves, stale replies, cleanup, worker replacement, and a real worker thread. CI runs for stacked PRs as well as PRs targeting main.
Validated with all 26 regression tests on Node 18,
npm run lint(Standard and TypeScript), andnpm run dist.The storage adapter interface is unchanged. Server-side saves add a Redis and storage read per save. Custom persistence workers must echo
requestIdwith the room; server and worker should use matching package versions. Storage must reject failed saves. Storage-enforced commit ordering and Redis expiration/eviction remain separate concerns.