Repository navigation
Exclude PmcProbe from packing and skip duplicate pushes on release - #37
Merged
Merged
Conversation
PmcProbe was missing IsPackable=false, so the release workflow packed and pushed PmcProbe.1.1.0.nupkg, which the NuGet API key has no permission for (403) — failing the job after the real packages had already been pushed. Also adds --skip-duplicate to nuget push so re-running a release with the same tag succeeds for already-published packages. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failed Release 1.1.0 run.
What happened:
sandbox/PmcProbe(added in #36) was missing<IsPackable>false</IsPackable>(unlike ConsoleApp1 / DryDB.Benchmark), sodotnet packon the solution producedPmcProbe.1.1.0.nupkgand the publish step tried to push it — the NuGet API key has no permission for that package ID, so the push failed with 403 after all five real packages had already been pushed successfully.create-releasewas then skipped, so nuget.org has DryDB 1.1.0 but there is no GitHub release/tag yet.This PR
IsPackable=falseto PmcProbe (verified: solution pack now yields exactly the 5 DryDB packages)--skip-duplicatetodotnet nuget push, so re-running the release with the same tag succeeds for the already-published 1.1.0 packagesAfter merging: re-run the Release workflow with tag
1.1.0(dry-run false). The five existing packages will be skipped as duplicates andcreate-releasewill create the draft release and tag.🤖 Generated with Claude Code