Skip to content

Add evidence-backed workflow feedback and priority escalation - #490

Merged
johnlanni merged 4 commits into
mainfrom
codex/workflow-feedback
Nov 17, 2026
Merged

johnlanni merged 4 commits into
mainfrom
codex/workflow-feedback

Conversation

@johnlanni

@johnlanni johnlanni commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Make feedback preview, recording, deduplication and counting available after ordinary issue-spec init. The built-in policy suggests priority/high at three confirmed occurrences.
  • Use feedback configure when the destination wants a custom threshold or automatic escalation. A threshold-only policy inherits the remaining defaults. The generated guidance offers feedback during authorized tasks, and projects can refine routing and publication rules in guidance.shared.
  • GitHub checks its ordinary label permission. Self-hosted uses Issue creation permission for feedback promotion and rechecks the published policy, stored evidence, Issue state, holds and target label in the mutation transaction. Its general issue-label API uses triage permission.
  • Revalidate the published policy Issue and current evidence before GitHub label writes. Automatic previews check target-label availability with a read-only request.

Closes #472

Validation

  • Both backends used the two independent catalog deploy failures from HiRoute #495 and one synthetic third release.
  • In a GitHub test repository, a fresh init installed the guide and enabled the default path without a published policy. Preview and concurrent retries kept the count correct. The third event suggested promotion. A threshold-only policy suggested at two. An injected 403 on the GitHub label request preserved the comment, and a real authorized retry added the label on the same event.
  • The self-hosted HTTP and PostgreSQL integration exercised default and threshold-only policies against a repository with a separate code Source Binding. An Issue creator successfully promoted a qualifying Issue. The normal label route denied that same caller. The feedback route also rejected missing Issue creation permission and respected below-threshold evidence, stale policy, maintainer hold and closure.
  • make test-fast and affected PostgreSQL, CLI and template tests passed. Workflow update preview was read-only and repeated generation produced zero changes.
  • Regression tests cover withdrawn evidence and an edited policy Issue before GitHub promotion, successful promotion with current evidence, and read-only previews with a missing or available label on both profiles. The PostgreSQL-backed self-hosted scenario also asserts the missing-label preview.

Signed-off-by: 澄潭 <zty98751@alibaba-inc.com>
Signed-off-by: 澄潭 <zty98751@alibaba-inc.com>
Signed-off-by: 澄潭 <zty98751@alibaba-inc.com>
Signed-off-by: 澄潭 <zty98751@alibaba-inc.com>
@johnlanni
johnlanni merged commit 6b197b2 into main Nov 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide reusable evidence-backed workflow feedback conventions

1 participant