feat: optional pprof endpoints via pprof_enabled - #1056
Conversation
Mounts net/http/pprof under /debug/pprof/ on the service HTTP port for every service type when enabled. Off by default; the handlers are unauthenticated.
alexbouchardd
left a comment
There was a problem hiding this comment.
Do that need to be documented seems oddly specific, who is that helpful for?
Sorry, I don't follow. Are you talking about the config documentation? We can certainly keep it shorter if that's the comment. |
|
I don't understand who this flag is for and in which context, which I imagine most people reading the config doc wouldn't either |
|
I don't believe this flag is documented in the config doc. The PR doesn't edit any markdown file, and we don't generate config doc from code anymore. As for what this flag is, it's to enabled Golang's This is the 2nd or 3rd time that I've needed this so figured it would be a good addition. Also it's a common-ish practice AFAIK, for example: elastic/apm-server#8002 |
Adds
pprof_enabled/PPROF_ENABLED(default off). When set,net/http/pprofis mounted under/debug/pprof/on the service HTTP port, for every service type — so a delivery or log worker can be profiled in place, not just the API.The handlers are unauthenticated, so this is strictly opt-in and meant for ports that aren't publicly reachable.
🤖 Generated with Claude Code
https://claude.ai/code/session_011ox7wgp77JimQcPkV3LDa1