Skip to content

feat(docker): reuse build digests and skip redundant setup - #953

Merged
neilime merged 3 commits into
mainfrom
perf/475-p23-publication-setup
Nov 11, 2026
Merged

neilime merged 3 commits into
mainfrom
perf/475-p23-publication-setup

Conversation

@neilime

@neilime neilime commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Single-platform builds already publish their tags and return an immutable digest. Publication currently discards that digest, initializes Docker/Buildx and resolves the tags again; attestation also initializes Docker only to authenticate to the registry.

This change reuses validated single-platform source digests and adds setup-docker: false to the existing setup action. Publication skips Docker/Buildx setup when every image has a reusable digest. Attestation uses registry authentication only. Runners with an existing Docker CLI avoid daemon setup; runners without the CLI retain the installation fallback. Tag-only inputs, multi-platform assembly and explicit tag cloning retain their inspection path. Malformed tags and conflicting digest metadata fail before publication.

Registry credentials, cosign signing, provenance subjects and build-job permissions remain intact. The publication job no longer requests unused attestation-write permission. No cache or DAG changes are included.

Implements P2.3 of Pleey's CI optimization plan, following review of Pleey #553.

Validation:

  • Final full CI: 167 jobs passed, 10 intentional skips. Includes single/multi-platform manifests, signed-image verification, mixed-platform attestations, registry-only login with an unreachable daemon and rejected credentials.
  • Local publication/retry checks and Super-Linter passed, including malformed tags and the existing/missing Docker CLI paths.
  • Existing input/output contracts, job dependencies and build/attestation permissions checked against main. Changed action readmes regenerated with CI Dokumentor.

Initial candidate action medians across the platform/signing matrix: single-platform publication 19.5s → 1s; attestation registry setup 12.5s → 1s. Multi-platform publication remains approximately unchanged (23s → 23.5s). These compare a previous main run with the initial candidate run, not controlled repeated benchmarks or Pleey end-to-end measurements. The final revision also passed: its observed medians were 1s for single-platform publication and 1.5s for attestation setup.

The ADR records ranges, whole-job/cleanup timings, compatibility and limitations. Downstream adoption follows upstream review and release.

@github-actions github-actions Bot added the type: performance Improves performance label Nov 11, 2026
@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Internal - Pull request - Continuous Integration - Test results

Workflow run and full reports · Commit 529bf07

Jobs: 2 success · 0 failure · 0 cancelled · 0 skipped · 0 abandoned.

Test: 14 passed · 0 failed · 0 skipped.

Test details

Test results

Test Results

Status Count
✅ Passed 14
❌ Failed 0
⏭️ Skipped 0
Total 14

✅ Pass Rate: 100.0%

Job results and report availability
Job Result Report artifacts
lint success 1
test-action-helm-release-chart success 1

Only this attempt is included. On partial reruns, rerun all producer jobs for complete reports. CodeQL findings remain in code scanning; other diagnostics remain in the job logs.

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Internal - Pull request - Continuous Integration - Code coverage

Workflow run and full reports · Commit 529bf07

Jobs: 2 success · 0 failure · 0 cancelled · 0 skipped · 0 abandoned.

Coverage: 1 source report(s); percentages remain separate.

Coverage details

Coverage results

Coverage

Metric Covered Total Percentage
Lines 102 102 100.00%
Branches 17 17 100.00%
Functions 4 4 100.00%

Overall: 100.00% 🟢
🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

Job results and report availability
Job Result Report artifacts
lint success 1
test-action-helm-release-chart success 1

Only this attempt is included. On partial reruns, rerun all producer jobs for complete reports. CodeQL findings remain in code scanning; other diagnostics remain in the job logs.

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Internal - Pull request - Continuous Integration - Lint results

Workflow run and full reports · Commit 529bf07

Jobs: 2 success · 0 failure · 0 cancelled · 0 skipped · 0 abandoned.

Lint: Collected diagnostics and Super-Linter summaries. Execution status is included in the job outcomes.

Super-Linter details

Super-linter summary

Language Validation result
BIOME_FORMAT Pass ✅
BIOME_LINT Pass ✅
CHECKOV Pass ✅
GITHUB_ACTIONS Pass ✅
GITHUB_ACTIONS_ZIZMOR Pass ✅
GITLEAKS Pass ✅
GIT_COMMITLINT Pass ✅
GIT_MERGE_CONFLICT_MARKERS Pass ✅
JSCPD Pass ✅
MARKDOWN Pass ✅
MARKDOWN_PRETTIER Pass ✅
NATURAL_LANGUAGE Pass ✅
PRE_COMMIT Pass ✅
SPELL_CODESPELL Pass ✅
TRIVY Pass ✅
YAML Pass ✅
YAML_PRETTIER Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter
Super-linter revision: 2da136927bd4a73596db63044b504547c62cb854
Super-linter version: 9.0.0

Job results and report availability
Job Result Report artifacts
lint success 1
test-action-helm-release-chart success 1

Only this attempt is included. On partial reruns, rerun all producer jobs for complete reports. CodeQL findings remain in code scanning; other diagnostics remain in the job logs.

@neilime neilime changed the title perf(docker): reuse build digests and skip redundant setup feat(docker): reuse build digests and skip redundant setup Nov 11, 2026
@github-actions github-actions Bot added the type: feature Introduces a new feature label Nov 11, 2026
@neilime
neilime merged commit 03d8c50 into main Nov 11, 2026
203 checks passed
@neilime
neilime deleted the perf/475-p23-publication-setup branch November 11, 2026 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: feature Introduces a new feature type: performance Improves performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant