Skip to content

fix(release): upload assets without a checkout - #514

Merged
neilime merged 1 commit into
mainfrom
fix/release-assets-without-checkout
Nov 11, 2026
Merged

neilime merged 1 commit into
mainfrom
fix/release-assets-without-checkout

Conversation

@neilime

@neilime neilime commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

The Node.js release workflow finalizes releases in a job without a checkout. release/update currently calls gh release upload without repository context, so it fails with fatal: not a git repository after npm publication succeeds. This blocked Reactionable CLI v1.3.0.

Set GH_REPO to the caller repository for asset uploads. Extend the existing release integration test to remove Git metadata before uploading an artifact and publishing the draft, then verify the uploaded asset name, size, and digest.

Validation: both YAML files parse; the embedded upload shell passes bash -n; a local isolated upload harness reproduces the missing-repository failure and passes with the fix; git diff --check passes. The release integration test passed on GitHub, including the upload without Git metadata. All PR checks passed.

@github-actions github-actions Bot added the type: fix Fixes a bug label Nov 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Internal - Pull request - Continuous Integration - Test results

Workflow run and full reports · Commit 3e53c26

Jobs: 5 success · 0 failure · 0 cancelled · 0 skipped · 0 abandoned.

Test: 116 passed · 0 failed · 0 skipped.

Test details

Test results

Test Results

Status Count
✅ Passed 116
❌ Failed 0
⏭️ Skipped 0
Total 116
Suite Passed Failed Skipped
AssetManager.copyAssetFromWorkspace 1 0 0
AssetManager.rewriteContent 1 0 0
createSitePage 1 0 0
GitEvidenceService 2 0 0
index.run 1 0 0
LinkEvidenceService 1 0 0
LlmSummaryService 2 0 0
LlmSummaryService provider retries 15 0 0
prepareSite 1 0 0
ReleaseSummaryCore 4 0 0
rewritePageLinks 1 0 0
Unknown Suite 84 0 0
WorkspacePathResolver.resolveExistingWithinWorkspace 2 0 0

✅ Pass Rate: 100.0%

Job results and report availability
Job Result Report artifacts
lint success 1
test-action-deploy-jekyll-jampack success 2
test-action-release-get-configuration success 1
test-action-release-prepare-and-plan success 2
test-action-release-summarize-changelog success 1

Only this attempt is included. On partial reruns, rerun all producer jobs for complete reports. CodeQL findings remain in code scanning; other diagnostics remain in the job logs.

@github-actions

Copy link
Copy Markdown
Contributor

Internal - Pull request - Continuous Integration - Code coverage

Workflow run and full reports · Commit 3e53c26

Jobs: 5 success · 0 failure · 0 cancelled · 0 skipped · 0 abandoned.

Coverage: 5 source report(s); percentages remain separate.

Coverage details

Coverage results

ci-reports-1-test-action-deploy-jekyll-jampack-actions-deploy-jekyll-4e7dead3-cbd4-4b9e-8461-1e9539529be6/lcov.info

Coverage

Metric Covered Total Percentage
Lines 638 707 90.24%
Branches 74 114 64.91%
Functions 45 45 100.00%

Overall: 90.24% 🟢
🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩⬜⬜

ci-reports-1-test-action-release-get-configuration-actions-release-get-configuration-7de7491c-ef63-49fc-a4fc-0bc9226e9b99/lcov.info

Coverage

Metric Covered Total Percentage
Lines 75 81 92.59%
Branches 18 21 85.71%
Functions 4 5 80.00%

Overall: 92.59% 🟢
🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩⬜

ci-reports-1-test-action-release-prepare-and-plan-actions-release-plan-b45f7641-10ba-475f-bfdb-526021f4336c/lcov.info

Coverage

Metric Covered Total Percentage
Lines 93 93 100.00%
Branches 34 34 100.00%
Functions 3 3 100.00%

Overall: 100.00% 🟢
🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

ci-reports-1-test-action-release-prepare-and-plan-actions-release-prepare-fe56b915-92ec-4639-9116-936e8ab589ec/lcov.info

Coverage

Metric Covered Total Percentage
Lines 4961 9032 54.93%
Branches 633 1074 58.94%
Functions 224 485 46.19%

Overall: 54.93% 🔴
🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜

ci-reports-1-test-action-release-summarize-changelog-actions-release-summarize-changelog-6310a302-54fc-4559-bdb4-228e7d5dbdf3/lcov.info

Coverage

Metric Covered Total Percentage
Lines 624 808 77.23%
Branches 79 115 68.70%
Functions 33 37 89.19%

Overall: 77.23% 🟡
🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨⬜⬜⬜⬜⬜

Job results and report availability
Job Result Report artifacts
lint success 1
test-action-deploy-jekyll-jampack success 2
test-action-release-get-configuration success 1
test-action-release-prepare-and-plan success 2
test-action-release-summarize-changelog success 1

Only this attempt is included. On partial reruns, rerun all producer jobs for complete reports. CodeQL findings remain in code scanning; other diagnostics remain in the job logs.

@github-actions

Copy link
Copy Markdown
Contributor

Internal - Pull request - Continuous Integration - Lint results

Workflow run and full reports · Commit 3e53c26

Jobs: 5 success · 0 failure · 0 cancelled · 0 skipped · 0 abandoned.

Lint: Collected diagnostics and Super-Linter summaries. Execution status is included in the job outcomes.

Super-Linter details

Super-linter summary

Language Validation result
BIOME_FORMAT Pass ✅
BIOME_LINT Pass ✅
CHECKOV Pass ✅
GITHUB_ACTIONS Pass ✅
GITHUB_ACTIONS_ZIZMOR Pass ✅
GITLEAKS Pass ✅
GIT_COMMITLINT Pass ✅
GIT_MERGE_CONFLICT_MARKERS Pass ✅
JSCPD Pass ✅
PRE_COMMIT Pass ✅
SPELL_CODESPELL Pass ✅
TRIVY Pass ✅
YAML Pass ✅
YAML_PRETTIER Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter
Super-linter revision: 2da136927bd4a73596db63044b504547c62cb854
Super-linter version: 9.0.0

Job results and report availability
Job Result Report artifacts
lint success 1
test-action-deploy-jekyll-jampack success 2
test-action-release-get-configuration success 1
test-action-release-prepare-and-plan success 2
test-action-release-summarize-changelog success 1

Only this attempt is included. On partial reruns, rerun all producer jobs for complete reports. CodeQL findings remain in code scanning; other diagnostics remain in the job logs.

@neilime
neilime merged commit 5b82149 into main Nov 11, 2026
98 checks passed
@neilime
neilime deleted the fix/release-assets-without-checkout branch November 11, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: fix Fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant