Skip to content

ci: update shared workflows and separate Helm validation from publication - #525

Open
neilime wants to merge 1 commit into
mainfrom
ci/update-shared-workflows-20261117
Open

neilime wants to merge 1 commit into
mainfrom
ci/update-shared-workflows-20261117

Conversation

@neilime

@neilime neilime commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Deploy-chart now prepares and validates the chart in a dedicated CI job, then publishes and signs the exact validated artifact in a separate job before dispatching deployment. Publication uses release-chart with the immutable artifact ID, archive name and checksum; it receives no test parameters and does not rebuild the chart.

The optional oci-registry-pull-password secret is used only by read-only chart validation. Publication credentials stay in the publishing job. Preserve the existing OCI namespace, repository-based chart name, publication concurrency and success-gated deployment. Publication-only retries reuse the validated artifact; missing or expired artifacts require validation again. Custom runners need Docker/Kind for validation. The workflow reference is regenerated with CI Dokumentor.

Shared versions: ci-github-common 4.3.0, ci-github-container 4.2.0 and ci-github-nodejs 3.1.0, pinned to immutable release commits.

Validation: 32 existing tests of the released Helm publication action pass, covering archive selection, checksum failures, retries and cleanup. The two Helm call contracts, artifact handoff, permission/credential separation and preserved namespace were checked. Actionlint, offline Zizmor, YAML/Markdown formatting, text lint and git diff --check pass. Existing chart-value conversion checks cover image digests, tag placeholders and deferred deployment values; that script is unchanged. No chart publication or deployment was dispatched.

@github-actions github-actions Bot added the type: maintenance Performs maintenance work label Nov 17, 2026
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Internal - Pull request - Continuous Integration - Test results

Workflow run and full reports · Commit 434cc86

Jobs: 5 success · 0 failure · 0 cancelled · 0 skipped · 0 abandoned.

Test: 116 passed · 0 failed · 0 skipped.

Test details

Test results

Test Results

Status Count
✅ Passed 116
❌ Failed 0
⏭️ Skipped 0
Total 116
Suite Passed Failed Skipped
AssetManager.copyAssetFromWorkspace 1 0 0
AssetManager.rewriteContent 1 0 0
createSitePage 1 0 0
GitEvidenceService 2 0 0
index.run 1 0 0
LinkEvidenceService 1 0 0
LlmSummaryService 2 0 0
LlmSummaryService provider retries 15 0 0
prepareSite 1 0 0
ReleaseSummaryCore 4 0 0
rewritePageLinks 1 0 0
Unknown Suite 84 0 0
WorkspacePathResolver.resolveExistingWithinWorkspace 2 0 0

✅ Pass Rate: 100.0%

Job results and report availability
Job Result Report artifacts
lint success 1
test-action-deploy-jekyll-jampack success 2
test-action-release-get-configuration success 1
test-action-release-prepare-and-plan success 2
test-action-release-summarize-changelog success 1

Only this attempt is included. On partial reruns, rerun all producer jobs for complete reports. CodeQL findings remain in code scanning; other diagnostics remain in the job logs.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Internal - Pull request - Continuous Integration - Code coverage

Workflow run and full reports · Commit 434cc86

Jobs: 5 success · 0 failure · 0 cancelled · 0 skipped · 0 abandoned.

Coverage: 5 source report(s); percentages remain separate.

Coverage details

Coverage results

ci-reports-1-test-action-deploy-jekyll-jampack-actions-deploy-jekyll-31bbffac-d773-4ac9-9eff-7b9d0e4a55b0/lcov.info

Coverage

Metric Covered Total Percentage
Lines 638 707 90.24%
Branches 74 114 64.91%
Functions 45 45 100.00%

Overall: 90.24% 🟢
🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩⬜⬜

ci-reports-1-test-action-release-get-configuration-actions-release-get-configuration-b911ccb7-1839-4336-999e-056a5be72926/lcov.info

Coverage

Metric Covered Total Percentage
Lines 75 81 92.59%
Branches 18 21 85.71%
Functions 4 5 80.00%

Overall: 92.59% 🟢
🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩⬜

ci-reports-1-test-action-release-prepare-and-plan-actions-release-plan-71ef9414-d9b3-40b1-bb28-f495dc76c913/lcov.info

Coverage

Metric Covered Total Percentage
Lines 93 93 100.00%
Branches 34 34 100.00%
Functions 3 3 100.00%

Overall: 100.00% 🟢
🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

ci-reports-1-test-action-release-prepare-and-plan-actions-release-prepare-30bf1c68-a022-46e1-9354-e8e5b64e1c88/lcov.info

Coverage

Metric Covered Total Percentage
Lines 4961 9032 54.93%
Branches 633 1074 58.94%
Functions 224 485 46.19%

Overall: 54.93% 🔴
🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜

ci-reports-1-test-action-release-summarize-changelog-actions-release-summarize-changelog-7c17ec76-3c69-4087-9173-5303f8aad1e7/lcov.info

Coverage

Metric Covered Total Percentage
Lines 624 808 77.23%
Branches 79 115 68.70%
Functions 33 37 89.19%

Overall: 77.23% 🟡
🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨⬜⬜⬜⬜⬜

Job results and report availability
Job Result Report artifacts
lint success 1
test-action-deploy-jekyll-jampack success 2
test-action-release-get-configuration success 1
test-action-release-prepare-and-plan success 2
test-action-release-summarize-changelog success 1

Only this attempt is included. On partial reruns, rerun all producer jobs for complete reports. CodeQL findings remain in code scanning; other diagnostics remain in the job logs.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Internal - Pull request - Continuous Integration - Lint results

Workflow run and full reports · Commit 434cc86

Jobs: 5 success · 0 failure · 0 cancelled · 0 skipped · 0 abandoned.

Lint: Collected diagnostics and Super-Linter summaries. Execution status is included in the job outcomes.

Super-Linter details

Super-linter summary

Language Validation result
BIOME_FORMAT Pass ✅
BIOME_LINT Pass ✅
CHECKOV Pass ✅
GITHUB_ACTIONS Pass ✅
GITHUB_ACTIONS_ZIZMOR Pass ✅
GITLEAKS Pass ✅
GIT_COMMITLINT Pass ✅
GIT_MERGE_CONFLICT_MARKERS Pass ✅
JSCPD Pass ✅
MARKDOWN Pass ✅
MARKDOWN_PRETTIER Pass ✅
NATURAL_LANGUAGE Pass ✅
PRE_COMMIT Pass ✅
SPELL_CODESPELL Pass ✅
TRIVY Pass ✅
YAML Pass ✅
YAML_PRETTIER Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter
Super-linter revision: 2da136927bd4a73596db63044b504547c62cb854
Super-linter version: 9.0.0

Job results and report availability
Job Result Report artifacts
lint success 1
test-action-deploy-jekyll-jampack success 2
test-action-release-get-configuration success 1
test-action-release-prepare-and-plan success 2
test-action-release-summarize-changelog success 1

Only this attempt is included. On partial reruns, rerun all producer jobs for complete reports. CodeQL findings remain in code scanning; other diagnostics remain in the job logs.

@neilime
neilime force-pushed the ci/update-shared-workflows-20261117 branch 2 times, most recently from 54050c9 to 670ca4c Compare November 17, 2026 13:10
Comment thread .github/workflows/deploy-chart.yml Outdated
values: ${{ needs.prepare-chart.outputs.chart-values }}
oci-registry: ${{ inputs.oci-registry }}
oci-repository: ${{ github.repository }}/charts/${{ inputs.chart-name }}
test-oci-registry: ${{ inputs.oci-registry }}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm concerned about having test-* inputs on a release workflow

@neilime
neilime force-pushed the ci/update-shared-workflows-20261117 branch from 670ca4c to e7f3af0 Compare November 17, 2026 13:25
@neilime neilime changed the title ci: adopt stable shared workflows and Helm validation ci: update shared workflows and separate Helm validation from publication Nov 17, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: maintenance Performs maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant