Conversation
ArthurZucker
left a comment
ArthurZucker
left a comment
Collaborator
There was a problem hiding this comment.
A bit too many unitary tests! Python should not test the rust layer, just the python layer.
Test should be quite minal please!
juste making sure the outputs are tokens, not string!
Comment on lines
+188
to
+189
| /// Encodes the given text and returns the string representation of each token. | ||
| /// |
Collaborator
There was a problem hiding this comment.
Let's make it return both the ids maybe? so they are not "thrown" away?
| } | ||
| } | ||
|
|
||
| /// Decode a slice of token ids to a Vec of the tokens' string representation |
Comment on lines
+92
to
+101
| if !self.is_byte_level() { | ||
| return self.vocab.id_to_token(id); | ||
| } | ||
| let bytes = self.id_to_token_bytes(id)?; | ||
| Some( | ||
| bytes | ||
| .iter() | ||
| .map(|&b| BYTES_CHAR_LOOKUP[b as usize]) | ||
| .collect(), | ||
| ) |
Collaborator
There was a problem hiding this comment.
MMM okay, you're making sure they are printable I guess.
K, makes sense.
Contributor
Author
There was a problem hiding this comment.
Matches the legacy .tokenize()
Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>
ArthurZucker
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.