IBX-6773: Fixed loading Bookmarks for non-accessible content items - #476
Open
vidarl wants to merge 44 commits into
Open
IBX-6773: Fixed loading Bookmarks for non-accessible content items#476vidarl wants to merge 44 commits into
vidarl wants to merge 44 commits into
Conversation
vidarl
force-pushed
the
IBX-6773_Bookmarks_for_non-accessible_contents_cause_exception_4.6
branch
from
February 12, 2025 12:23
bdac332 to
9164daa
Compare
Closed
6 tasks
|
adamwojs
changed the title
vidarl
force-pushed
the
IBX-6773_Bookmarks_for_non-accessible_contents_cause_exception_4.6
branch
from
February 23, 2026 15:43
9164daa to
ec96060
Compare
konradoboza
reviewed
Feb 24, 2026
vidarl
commented
Feb 24, 2026
vidarl
commented
Feb 24, 2026
ibexa-workflow-automation-1
Bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
February 24, 2026 08:56
konradoboza
reviewed
Feb 24, 2026
konradoboza
left a comment
konradoboza
left a comment
Contributor
There was a problem hiding this comment.
Did you make sure none of the deprecated classes are still in use?
Contributor
Author
|
@konradoboza : FYI : Had to add related PR : ibexa/admin-ui#1835 |
konradoboza
reviewed
Feb 25, 2026
vidarl
force-pushed
the
IBX-6773_Bookmarks_for_non-accessible_contents_cause_exception_4.6
branch
from
August 3, 2026 09:49
0c025cd to
fd7cc86
Compare
…tFilteringTest and LocationFilteringTest
alongosz
reviewed
Aug 5, 2026
alongosz
left a comment
alongosz
left a comment
Member
There was a problem hiding this comment.
It looks like it's almost done, great work @vidarl 💪
I have one general remark to test coverage - it's extensive, but I don't see an integration test case that reproduces the scenario which created this bug report - remove permissions for an item user previously has bookmarked.
Other remarks:
…ck in IsBookmarkedQueryBuilder
…y in IsBookmarked criterion
… in IdSortClauseQueryBuilder
…itoryException, log at error level
vidarl
force-pushed
the
IBX-6773_Bookmarks_for_non-accessible_contents_cause_exception_4.6
branch
from
August 6, 2026 13:10
46b69f8 to
493a1df
Compare
vidarl
force-pushed
the
IBX-6773_Bookmarks_for_non-accessible_contents_cause_exception_4.6
branch
2 times, most recently
from
August 7, 2026 09:06
b3ffa7f to
fb6c2bd
Compare
vidarl
force-pushed
the
IBX-6773_Bookmarks_for_non-accessible_contents_cause_exception_4.6
branch
from
August 7, 2026 10:39
fb6c2bd to
4ea28c1
Compare
Contributor
Author
@alongosz : Added in 4ea28c1: Added regression tests for bookmarks of inaccessible and removed items PR should not be ready again for your sharp eyes |
alongosz
reviewed
Aug 25, 2026
| /** | ||
| * Loads bookmarks owned by user. | ||
| * | ||
| * @deprecated 4.6.32 The "Handler::loadUserBookmarks()" method is deprecated, will be removed in 6.0.0. Use "LocationService::find()" and "Criterion\Location\IsBookmarked" instead. |
Member
There was a problem hiding this comment.
Note
Let's keep an eye out for this when merging - 4.6.32 is outdated since last week - (added a note in the PR's description) and bump it right before merge.
|
alongosz
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Related PRs:
loadBookmarkscall with Repository filtering requirements admin-ui#1835Description:
If user bookmark some location which he later looses access too, then the bookmark list in admin-ui fails with an exception.
Simply fixing
BookmarkService::loadBookmarks()would be easy. The problem is to implementcountUserBookmarks()in persistence layer and having it taking into account user permissions so that BC would be kept.Talked with Adam on how to solve this without breaking BC and he suggested implementing it using filtering
The Bookmark filter will only work with location filtering (LocationService::find()), not with content (ContentService::find())Code was initially based on ezsystems/ezplatform-kernel#408 which was not approved and merge in time before 3.3 went EO, but has been heavily modified since.
For QA:
Read ticket for info on how to reproduce
Documentation:
Documentation for the new filter needs to be made, indeed