[Media Common] Fetch googletest from upstream for Linux ULT instead o… - #2026
Open
XinfengZhang wants to merge 1 commit into
Open
XinfengZhang wants to merge 1 commit into
XinfengZhang wants to merge 1 commit into
Conversation
…f vendoring Make the Linux ULT (devult) pull googletest from upstream on demand and remove the ~25k-line in-tree copy of googletest, so a normal driver build carries no googletest dependency. WHAT changed: - Add a BUILD_MEDIA_ULT option (default OFF) in media_top_cmake.cmake and AND it into the existing ULT gate. With the default, the linux/ult subdirectory is not added, so no googletest is downloaded and no ULT is built. - In linux/ult/CMakeLists.txt, fetch googletest via FetchContent from a configurable repository/tag (default v1.13.0) into a fixed build-tree location, with BUILD_GMOCK and INSTALL_GTEST disabled. GTEST_GIT_REPOSITORY and GTEST_GIT_TAG are cache variables so an internal mirror can be used. - In ult_app/CMakeLists.txt, drop add_subdirectory(googletest) and the vendored include path, and link the fetched gtest target instead of libgtest. - Delete the vendored media_driver/linux/ult/ult_app/googletest tree. WHY: The vendored googletest was a large third-party copy compiled unconditionally whenever the internal test suite was enabled. Fetching it from upstream keeps the repository lean, lets the ULT track a known googletest version, and makes the ULT (and its googletest dependency) fully opt-in. Signed-off-by: Carl.Zhang <carl.zhang@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…f vendoring
Make the Linux ULT (devult) pull googletest from upstream on demand and remove the ~25k-line in-tree copy of googletest, so a normal driver build carries no googletest dependency.
WHAT changed:
WHY:
The vendored googletest was a large third-party copy compiled unconditionally whenever the internal test suite was enabled. Fetching it from upstream keeps the repository lean, lets the ULT track a known googletest version, and makes the ULT (and its googletest dependency) fully opt-in.