Repository navigation
[IN-189] fix: stop deleting previous sharings on public share and invite creation - #1257
Merged
Merged
Conversation
apsantiso
force-pushed
the
fix/IN-189-sharing-delete-before-ownership
branch
from
October 29, 2026 11:09
f08a28a to
f0b78a8
Compare
apsantiso
marked this pull request as ready for review
October 29, 2026 11:10
jzunigax2
approved these changes
Oct 29, 2026
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Creating a public share or an invite no longer deletes the item's previous sharings.
persistPreviousSharingwas a field we used for retrocompatibility.Why
Reported in security finding C07 (CWE-863: Incorrect Authorization) #1246
POST /sharingsdeleted an item's invites and private shares before checking ownership, so any user with the item UUID could revoke another user's sharing access.