Repository navigation
fix(signals-dashboard): keep hiding classroom desks stashed before desk groups - #22
Merged
Merged
Conversation
…sk groups Stash entries written before desk groups hold only a desk name, and the old dashboard hid the desk of that name in desks/ and in classroom/. The migration mapped every such entry to desks/<name>, so a stashed classroom desk reappeared after upgrading. Map each one to every built-in root that holds the desk, falling back to desks/<name>. Entries that already carry a desk id are unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a3e3bdc9-f091-4246-8b0f-3d3442cd59f2
Merged
8 of 17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #21, from Copilot's review of the same change in github/awesome-copilot#6302: github/awesome-copilot#6302 (comment)
Stash entries written before desk groups hold only a desk name, and the old dashboard hid the desk of that name in both
desks/andclassroom/. #21 mapped every such entry todesks/<name>, so a stashed classroom desk would reappear after upgrading, until its 48-hour stash expired. Each one now maps to every built-in root that holds the desk, falling back todesks/<name>. Entries that already carry a desk id are unchanged.Testing: the dashboard tests (
node --experimental-vm-modules --test) pass, 33 of 33. The new test covers a desk only inclassroom/and a name in bothdesks/andclassroom/; it fails without the fix.